generated from crossplane/provider-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch user credentials in sdk #78
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ab24fd6
feat: fetch user credentials in sdk
mariatsji e20268c
chore: simplify Secret by removing wrapper
mariatsji 177f553
chore: also scrap Secret.Reveal() and let string cast be used
mariatsji eef83fa
Update secret_test.go
mariatsji 0869c8c
chore: revert fmt.Sprintf suggestion, golangci-lint wants string()
mariatsji e2cdebf
chore: fix tests of Secret
mariatsji 586170c
Update internal/sdk/cloudian/sdk.go
mariatsji f8424de
Update internal/sdk/cloudian/sdk.go
mariatsji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package cloudian | ||
|
||
type Secret string | ||
|
||
func (s Secret) String() string { | ||
return "********" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package cloudian | ||
|
||
import ( | ||
"encoding/json" | ||
"testing" | ||
) | ||
|
||
func TestSecretUnmarshal(t *testing.T) { | ||
jsonString := `[{"accessKey":"124","secretKey":"x+2","createDate":1735894172440,"active":true}]` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't think we need to test the builtin go marshalling. Suggesting to simply remove the test. Obfuscating also seems a bit overkill, as the thing running this has access, and we should not print the thing in production. |
||
|
||
var secrets []SecurityInfo | ||
err := json.Unmarshal([]byte(jsonString), &secrets) | ||
if err != nil { | ||
t.Errorf("Error deserializing from JSON: %v", err) | ||
} | ||
|
||
if string(secrets[0].AccessKey) != "124" { | ||
t.Errorf("Expected string equality to 124, got %v", secrets[0].AccessKey) | ||
} | ||
|
||
if secrets[0].AccessKey.String() != "********" { | ||
mariatsji marked this conversation as resolved.
Show resolved
Hide resolved
|
||
t.Errorf("Expected obfuscated string, got %v", secrets[0].SecretKey) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the cloudian invoking endpoints have tests. We would have to introduce some interfaces and start mocking or stubbing I guess.
I've only tested curl against the cloudian API docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add some kind of Go REST module that we can easily stub out. Untested code is no good.