Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wakuext_getLatestVerificationRequestFrom is called way too often and we don't even show ID verif currently #16147

Closed
jrainville opened this issue Aug 19, 2024 · 0 comments · Fixed by #16149
Closed

wakuext_getLatestVerificationRequestFrom is called way too often and we don't even show ID verif currently #16147

jrainville opened this issue Aug 19, 2024 · 0 comments · Fixed by #16149
Assignees
@jrainville
Labels
bug Something isn't working core-team
Milestone
2.31.0 Beta

Comments

@jrainville
Copy link
Member

Bug Report

Description

When starting the app, we get a lot of wakuext_getLatestVerificationRequestFrom calls in the console.

We have two options:

  • Fix that and make it smarter/better
  • Remove those calls for now as we don't even support ID verification for now

Steps to reproduce

  1. Have an account with multiple contacts
  2. Login

Expected behavior

Few or no calls to wakuext_getLatestVerificationRequestFrom

Actual behavior

Tons of wakuext_getLatestVerificationRequestFrom calls, as seen here: #16144 (comment)

Additional Information

  • Status desktop version: 2.30 RC9
@jrainville jrainville added the bug Something isn't working label Aug 19, 2024
@jrainville jrainville added this to the 2.31.0 Beta milestone Aug 19, 2024
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Aug 19, 2024
@jrainville jrainville self-assigned this Aug 19, 2024
@jrainville jrainville mentioned this issue Aug 19, 2024
Closed
jrainville added a commit that referenced this issue Aug 19, 2024
@jrainville
chore: remove calls to getLatestVerificationRequestFrom
a9b48a9 
Fixes #16147

Since ID verification is disabled for now, we can remove the calls to getLatestVerificationRequestFrom.

If we want to have ID verification back, we can re-add those calls, but in my opinion, it should be done better from status-go directly, or only asking for the ID verif when looking at the contact's profile
@jrainville jrainville mentioned this issue Aug 19, 2024
Merged
jrainville added a commit that referenced this issue Aug 19, 2024
@jrainville
chore: remove calls to getLatestVerificationRequestFrom
9aab145 
Fixes #16147

Since ID verification is disabled for now, we can remove the calls to getLatestVerificationRequestFrom.

If we want to have ID verification back, we can re-add those calls, but in my opinion, it should be done better from status-go directly, or only asking for the ID verif when looking at the contact's profile
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Aug 19, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working core-team
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.31.0 Beta
Development

Successfully merging a pull request may close this issue.

chore: remove calls to getLatestVerificationRequestFrom status-im/status-desktop
1 participant
@jrainville