chore: remove calls to getLatestVerificationRequestFrom #16149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
alexjba
reviewed
Aug 19, 2024
src/app/modules/main/module.nim
Outdated
| @@ -1182,7 +1179,7 @@ method communityDataImported*[T](self: Module[T], community: CommunityDto) = | |||
|
|
|||
| method resolveENS*[T](self: Module[T], ensName: string, uuid: string, reason: string = "") = | |||
| if ensName.len == 0: | |||
| echo "error: cannot do a lookup for empty ens name" | |||
| err "error: cannot do a lookup for empty ens name" | |||
There was a problem hiding this comment.
Suggested change
| err "error: cannot do a lookup for empty ens name" | |
| error "error: cannot do a lookup for empty ens name" |
Fixes #16147 Since ID verification is disabled for now, we can remove the calls to getLatestVerificationRequestFrom. If we want to have ID verification back, we can re-add those calls, but in my opinion, it should be done better from status-go directly, or only asking for the ID verif when looking at the contact's profile
jrainville
force-pushed
the
fix/getLatestVerificationRequestFrom-clals
branch
from
a9b48a9 to
9aab145
Compare
igor-sirotin
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16147
Since ID verification is disabled for now, we can remove the calls to getLatestVerificationRequestFrom.
If we want to have ID verification back, we can re-add those calls, but in my opinion, it should be done better from status-go directly, or only asking for the ID verif when looking at the contact's profile
I tested with a timer and it doesn't save much on app start, but it's something. Also, it's a function that accesses the database, so it's better to not do it, and especially not that many times.