Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New onboarding: Privacy Policy and Terms of Use UI Issues #17098

Closed
Tracked by #17097
glitchminer opened this issue Jan 21, 2025 · 0 comments · Fixed by #17119
Closed
Tracked by #17097

New onboarding: Privacy Policy and Terms of Use UI Issues #17098

glitchminer opened this issue Jan 21, 2025 · 0 comments · Fixed by #17119
Assignees
@caybro
Labels
bug Something isn't working core-team
Milestone
2.33.0 Beta

Comments

@glitchminer
Copy link
Contributor

Metadata

Issue 1 - Button shows wrong label

Field Description
Current Behavior Button labeled 'OK'
Expected Behavior Button labeled 'Done'
Location/Screen Both Privacy policy and Terms of use pop ups
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=884-50497&m=dev

Issue 2 - External links not functioning

Field Description
Current Behavior External links are highlighted in blue but do nothing when clicked
Expected Behavior Links to URLs and email open in external app
Location/Screen Privacy policy and Terms of Use pop up
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=884-51045&m=dev

Issue 3 - Version and license incorrectly positioned

Field Description
Current Behavior Version is at the top, license is at the bottom
Expected Behavior Footer section containing version and license
Location/Screen Privacy policy and Terms of Use pop up
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=884-51045&m=dev
@glitchminer glitchminer added bug Something isn't working core-team labels Jan 21, 2025
@caybro caybro self-assigned this Jan 21, 2025
@caybro caybro mentioned this issue Jan 23, 2025
Merged
2 tasks
@caybro caybro moved this from Next to In Progress in Status Desktop/Mobile Board Jan 23, 2025
caybro added a commit that referenced this issue Jan 24, 2025
@caybro
fix: Privacy Policy and Terms of Use UI Issues
c5ebcbc 
- make it possible for the "OK" button text to be overridden
- use the correct "Done" text for those 2 popups (PP & TOU), as designed
in Figma

Fixes #17098
@caybro caybro linked a pull request Jan 24, 2025 that will close this issue
fix(KeycardCreateProfileFlow): swap the order of PIN and Seed pages #17119
Merged
2 tasks
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 24, 2025
@caybro caybro closed this as completed in c06d7f8 Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 24, 2025
@iurimatias iurimatias added this to the 2.33.0 Beta milestone Jan 29, 2025
@iurimatias iurimatias mentioned this issue Jan 29, 2025
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working core-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(KeycardCreateProfileFlow): swap the order of PIN and Seed pages status-im/status-desktop
3 participants
@iurimatias @caybro @glitchminer