New onboarding integration (happy paths) #17045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
jrainville
requested review from
glitchminer,
a team and
igor-sirotin
and removed request for
a team
|
I'll squash later, don't worry 😄 |
Jenkins BuildsClick to see older builds (56)
|
caybro
reviewed
Jan 10, 2025
ui/main.qml
Outdated
| stack.clear() | ||
| stack.push(splashScreenV2, { runningProgressAnimation: true }) | ||
| } | ||
| onKeycardFactoryResetRequested: { |
There was a problem hiding this comment.
This should start the keycard factory reset in a popup; something TODO
There was a problem hiding this comment.
Yeah, I haven't done any of the keycard flows yet. I'll need Igor's work for that
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
779c488 to
f3b437f
Compare
|
@caybro thanks for the review. I addressed you comments |
micieslak
force-pushed
the
feat/onboarding-rework-1
branch
2 times, most recently
from
d5524fd to
35b8620
Compare
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
77b5d44 to
bb284bd
Compare
|
@jrainville @caybro , I still have to complete the syncing flows but here's a summary of findings from the others. 14,16,17 are functional, the others are UI.
|
|
@glitchminer Thanks for the tests. I'll only reply to the functional ones since it's the ones I worked on
I do not have a Mac computer so I couldn't test this. I did put the I'll create a new issue for someone like Igor who has a Mac to check it out. edit: issue created here: #17085
This is still the default behaviour for the app when a display name doesn't exist or isn't found (like people in a community we don,t know). We can easily change it to be a shortened pubkey, but I didn't know if we have the "go" to finally make the transition. If we go this path, 3 word names will be gone from the app. I don't see in the new design if that's the wanted change. Let's ask @benjthayer
That sounds like a bug. I'll address it right now. |
|
@glitchminer I tried reproducing the problem 17 about metrics, but I can't. Is it in a particular flow? I tried the basic Create profile with password one. Also tried mnemonic |
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
bb284bd to
5b2d30f
Compare
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
3a0e9b9 to
c13a96b
Compare
This was referenced Jan 21, 2025
glitchminer
approved these changes
Jan 21, 2025
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
c13a96b to
8537b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17044
(I'll create a new issue for unhappy paths)
Branched on top of #16722
Integrates all the non-keycard flows for the new onboarding. All happy paths for those should work, including the pairing fallback.
Do note that the new onboarding only applies for new users. If you have a profile already, it will show the old startup/login/onboarding.
This is because the new screens for the Login are not implemented yet and the LoginView is super tied with the old startup module, so it's not worth it to extract it.
To use the new onboarding, you need to delete or rename your data folder.
Then, run the app with
export FLAG_ONBOARDING_V2_ENABLED=1.Affected areas
None by default, because all of the new stuff is behind a feature flag.
The only thing that goes outside the scope of the feature flag is a small change on the status-go side to enable creating accounts without a displayName. (status-go PR: status-im/status-go#6242)
Otherwise, if the feature flag is activated, the new onboarding module will be initiated instead of the old one and the new onboarding screens will show, but only for new users.
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
All flows except pairing (ignore the last part, I forgot to remove the forced error on pairing):
new-onboarding.webm
Pairing:
new-onboarding-pairing.webm
Impact on end user
Nothing for now as it's hidden behind the feature flag
How to test
export FLAG_ONBOARDING_V2_ENABLED=1Risk
Tick one:
Low risk because it is behind a feature flag, but it would be better to have it tested by a QA still to catch bugs as early as possible