Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New onboarding: Help Us Improve Status Button Label #17099

Closed
glitchminer opened this issue Jan 21, 2025 · 0 comments · Fixed by #17119
Closed

New onboarding: Help Us Improve Status Button Label #17099

glitchminer opened this issue Jan 21, 2025 · 0 comments · Fixed by #17119
Assignees
@caybro
Labels
bug Something isn't working core-team

Comments

@glitchminer
Copy link
Contributor

Metadata

Issue 4 - Button shows wrong label

Field Description
Current Behavior Button labeled 'OK'
Expected Behavior Button labeled 'Got it'
Location/Screen Help us improve Status
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=884-50314&m=dev
@glitchminer glitchminer added bug Something isn't working core-team labels Jan 21, 2025
@caybro caybro self-assigned this Jan 21, 2025
@caybro caybro moved this from Next to In Progress in Status Desktop/Mobile Board Jan 23, 2025
caybro added a commit that referenced this issue Jan 24, 2025
@caybro
fix: Help Us Improve Status Button Label
da536d8 
- use the "Got it" text for the OK button

Fixes #17099
@caybro caybro linked a pull request Jan 24, 2025 that will close this issue
fix(KeycardCreateProfileFlow): swap the order of PIN and Seed pages #17119
Merged
2 tasks
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 24, 2025
caybro added a commit that referenced this issue Jan 24, 2025
@caybro
fix: Help Us Improve Status Button Label
0aa85d5 
- use the "Got it" text for the OK button

Fixes #17099
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working core-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(KeycardCreateProfileFlow): swap the order of PIN and Seed pages status-im/status-desktop
2 participants
@caybro @glitchminer