Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite chat loading animation #12086

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

igor-sirotin
Copy link
Contributor

Fixes #11854
Requires status-im/status-go#3992

What does the PR do

  1. When chat is "marked as read", scrolling to first unseen message is stopped.

    method stopLoadingFirstMessage*(self: Module) =
    if self.controller.getSearchedMessageId() != self.view.model().getFirstUnseenMessageId():
    return
    self.resetMessageSearch()

  2. If there're no messages in the chat, consider initial message as loaded to hide loading animation.

    if messageId == "":
    self.initialMessagesLoaded = true

  3. Update status-go to get Hotfix: mark Chat and Pin archive messages as seen status-go#3992.

Screenshot of functionality

Screen.Recording.2023-09-05.at.17.59.22.mov

@status-im-auto
Copy link
Member

status-im-auto commented Sep 5, 2023

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0883f61 #1 2023-09-05 16:08:30 ~5 min tests/imports 📄log
✔️ 0883f61 #1 2023-09-05 16:09:06 ~6 min tests/nim 📄log
✔️ 0883f61 #1 2023-09-05 16:13:18 ~10 min macos/aarch64 🍎dmg
✔️ 0883f61 #1 2023-09-05 16:13:55 ~10 min tests/e2e 📄log
✔️ 0883f61 #1 2023-09-05 16:20:52 ~17 min linux/x86_64 📦tgz
✔️ 0883f61 #1 2023-09-05 16:27:50 ~24 min macos/x86_64 🍎dmg
✔️ 0883f61 #1 2023-09-05 16:34:52 ~31 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5a9001d #2 2023-09-05 22:42:53 ~4 min tests/imports 📄log
✔️ 5a9001d #2 2023-09-05 22:43:44 ~5 min tests/nim 📄log
✔️ 5a9001d #2 2023-09-05 22:45:46 ~7 min tests/e2e 📄log
✔️ 5a9001d #2 2023-09-05 22:46:03 ~7 min macos/x86_64 🍎dmg
✔️ 5a9001d #2 2023-09-05 22:46:58 ~8 min macos/aarch64 🍎dmg
✔️ 5a9001d #2 2023-09-05 22:53:19 ~15 min linux/x86_64 📦tgz
✔️ 5a9001d #2 2023-09-05 23:02:48 ~24 min windows/x86_64 💿exe
✔️ 52711b3 #3 2023-09-06 14:18:16 ~5 min tests/imports 📄log
✔️ 52711b3 #3 2023-09-06 14:20:00 ~7 min tests/nim 📄log
✔️ 52711b3 #3 2023-09-06 14:21:05 ~8 min macos/x86_64 🍎dmg
✔️ 52711b3 #3 2023-09-06 14:22:40 ~9 min macos/aarch64 🍎dmg
✔️ 52711b3 #3 2023-09-06 14:23:48 ~10 min tests/e2e 📄log
✔️ 52711b3 #3 2023-09-06 14:28:59 ~16 min linux/x86_64 📦tgz
✔️ 52711b3 #3 2023-09-06 14:39:27 ~26 min windows/x86_64 💿exe

@igor-sirotin igor-sirotin changed the title Fix/issue 11854 2 fix: Infinite chat loading animation Sep 6, 2023
@iurimatias iurimatias merged commit c3ac8f3 into release/0.14.x Sep 6, 2023
@iurimatias iurimatias deleted the fix/issue-11854-2 branch September 6, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants