Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: mark Chat and Pin archive messages as seen #3992

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

igor-sirotin
Copy link
Collaborator

Related: status-im/status-desktop#11854.

  1. Add option to force seen property for generated SYTEM_MESSAGE_PIN_MESSAGE

    if forceSeen {
    systemMessage.Seen = true
    }

  2. Apply workaround: Mark all ChatMessage and PinMessage from archives as seen.
    Currently we only mark "imported" messages as seen. But this doesn't cover imported PinMessages and therefore wasn't possible to mark generated SYTEM_MESSAGE_PIN_MESSAGE as Seen.

  3. Add processing of PinMessage when handling imported messages.
    I could introduce it together with #3991, but it totally makes sense here anyway. And adds backward compatibility for the future.

    case protobuf.ApplicationMetadataMessage_PIN_MESSAGE:
    err = m.handlePinMessageProtobuf(messageState, msg.UnwrappedPayload, msg, filter, true)

  4. Subscribe to spectated communities.
    Without it's easy to get into "infinite chat loading animation" in desktop app.

    if !community.Joined() && !community.Spectated() {

@status-im-auto
Copy link
Member

status-im-auto commented Sep 5, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 7531dbe #1 2023-09-05 15:55:16 ~2 min tests 📄log
✔️ 7531dbe #1 2023-09-05 15:55:34 ~3 min linux 📦zip
✔️ 7531dbe #1 2023-09-05 15:57:28 ~5 min android 📦aar
✔️ 7531dbe #1 2023-09-05 15:58:50 ~6 min ios 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ f3c5c07 #2 2023-09-05 16:43:29 ~54 sec tests 📄log
✔️ f3c5c07 #2 2023-09-05 16:43:36 ~1 min linux 📦zip
✔️ f3c5c07 #2 2023-09-05 16:43:44 ~1 min android 📦aar
✔️ f3c5c07 #2 2023-09-05 16:49:19 ~6 min ios 📦zip
✔️ 01f88f8 #3 2023-09-05 22:02:14 ~1 min linux 📦zip
✔️ 01f88f8 #3 2023-09-05 22:02:28 ~1 min android 📦aar
✔️ 01f88f8 #3 2023-09-05 22:05:56 ~4 min ios 📦zip
✔️ 01f88f8 #3 2023-09-05 22:30:09 ~28 min tests 📄log

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igor-sirotin igor-sirotin merged commit c19b32a into desktop/release/0.14.x Sep 5, 2023
@igor-sirotin igor-sirotin deleted the fix/infinite-loading-animation branch September 5, 2023 22:31
igor-sirotin added a commit that referenced this pull request Sep 7, 2023
* fix: Process community response for spectated communites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants