Hotfix: mark Chat
and Pin
archive messages as seen
#3992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: status-im/status-desktop#11854.
Add option to force
seen
property for generatedSYTEM_MESSAGE_PIN_MESSAGE
status-go/protocol/messenger_handler.go
Lines 852 to 854 in 7531dbe
Apply workaround: Mark all
ChatMessage
andPinMessage
from archives asseen
.Currently we only mark "imported" messages as seen. But this doesn't cover imported
PinMessage
s and therefore wasn't possible to mark generatedSYTEM_MESSAGE_PIN_MESSAGE
asSeen
.PinMessage.ThirdPartyMessage_ID
property #3991Add processing of
PinMessage
when handling imported messages.I could introduce it together with #3991, but it totally makes sense here anyway. And adds backward compatibility for the future.
status-go/protocol/messenger.go
Lines 3422 to 3423 in 7531dbe
Subscribe to spectated communities.
Without it's easy to get into "infinite chat loading animation" in desktop app.
status-go/protocol/messenger_communities.go
Line 2584 in 7531dbe