Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the status-go PR changes that fix #17223 mobile issue against the desktop app #12117

Closed
wants to merge 2 commits into from

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Sep 11, 2023

Closes #12111

@qa please do check the syncing feature in this PR which points to the changes of the status-go that fix mobile issue:

@saledjenic
Copy link
Contributor Author

@churik @qfrank here is the desktop app PR that points to the status-go changes that fix the mobile app issue.

@status-im-auto
Copy link
Member

status-im-auto commented Sep 11, 2023

Jenkins Builds

Click to see older builds (20)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2d84e2a #1 2023-09-11 09:37:59 ~5 min tests/statusq 📄log
✔️ 2d84e2a #1 2023-09-11 09:39:18 ~7 min tests/nim 📄log
✔️ 2d84e2a #1 2023-09-11 09:46:39 ~14 min macos/x86_64 🍎dmg
✔️ 2d84e2a #1 2023-09-11 09:47:58 ~15 min linux/x86_64 📦tgz
✔️ 2d84e2a #2 2023-09-11 09:53:48 ~8 min macos/aarch64 🍎dmg
✔️ 2d84e2a #1 2023-09-11 10:06:45 ~34 min tests/e2e 📄log
✔️ 2d84e2a #1 2023-09-11 10:11:07 ~38 min windows/x86_64 💿exe
✔️ 39a5321 #3 2023-09-11 11:05:58 ~5 min macos/aarch64 🍎dmg
✔️ 39a5321 #2 2023-09-11 11:06:28 ~5 min tests/nim 📄log
✔️ 39a5321 #2 2023-09-11 11:07:04 ~6 min tests/statusq 📄log
✔️ 39a5321 #2 2023-09-11 11:09:56 ~9 min macos/x86_64 🍎dmg
✔️ 39a5321 #2 2023-09-11 11:16:09 ~15 min linux/x86_64 📦tgz
✖️ 39a5321 #2 2023-09-11 11:29:34 ~28 min tests/e2e 📄log
✔️ 39a5321 #2 2023-09-11 11:29:51 ~29 min windows/x86_64 💿exe
✔️ 39a5321 #3 2023-09-11 13:01:30 ~35 min tests/e2e 📄log
✔️ 39a5321 #4 2023-09-13 12:48:47 ~5 min macos/aarch64 🍎dmg
✔️ 39a5321 #3 2023-09-13 12:49:47 ~6 min tests/statusq 📄log
✔️ 39a5321 #3 2023-09-13 12:49:57 ~6 min tests/nim 📄log
✔️ 39a5321 #3 2023-09-13 12:52:09 ~8 min macos/x86_64 🍎dmg
✔️ 39a5321 #3 2023-09-13 12:57:24 ~13 min linux/x86_64 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f42899c #5 2023-09-13 13:08:22 ~5 min tests/imports 📄log
✔️ f42899c #5 2023-09-13 13:09:30 ~6 min tests/nim 📄log
✔️ f42899c #5 2023-09-13 13:12:42 ~10 min macos/x86_64 🍎dmg
✔️ f42899c #6 2023-09-13 13:15:52 ~13 min tests/e2e 📄log
✔️ f42899c #5 2023-09-13 13:20:05 ~17 min linux/x86_64 📦tgz
✔️ f42899c #5 2023-09-13 13:28:27 ~25 min windows/x86_64 💿exe
✔️ f42899c #7 2023-09-15 07:45:16 ~5 min macos/aarch64 🍎dmg
✔️ 2cf2b4e #6 2023-09-15 11:17:51 ~3 min tests/imports 📄log
✔️ 2cf2b4e #6 2023-09-15 11:20:31 ~5 min tests/nim 📄log
✔️ 2cf2b4e #8 2023-09-15 11:22:25 ~7 min macos/aarch64 🍎dmg
✔️ 2cf2b4e #7 2023-09-15 11:22:33 ~8 min tests/e2e 📄log
✔️ 2cf2b4e #6 2023-09-15 11:22:38 ~8 min macos/x86_64 🍎dmg
✔️ 2cf2b4e #6 2023-09-15 11:31:19 ~16 min linux/x86_64 📦tgz
✔️ 2cf2b4e #6 2023-09-15 11:43:10 ~28 min windows/x86_64 💿exe

@anastasiyaig
Copy link
Contributor

alright, i will take a look @saledjenic

@saledjenic saledjenic changed the title check the status-go PR changes that fixes #17223 mobile issue against the desktop app check the status-go PR changes that fix #17223 mobile issue against the desktop app Sep 11, 2023
@churik
Copy link
Member

churik commented Sep 11, 2023

Thank you, results are status-im/status-mobile#17226 (comment)

@anastasiyaig
Copy link
Contributor

@saledjenic i noticed that the desktop app is stuck when u scan a QR code from mobile device. How to reproduce:

  1. install the build on mobile app and create new account there
  2. install the build on desktop app and select - I arelady use status -> Scan Sync code. Enable the camera access on your laptop and scan the QR displayed on mobile phone
Screenshot 2023-09-11 at 13 20 13

Console log:

Experimental support for Apple Silicon
INFO [09-11|13:18:10.960] Status backend initialized               backend=geth version=0.166.8 commit=46c0063be IpfsGatewayURL=https://ipfs.status.im/
INF 2023-09-11 13:18:11.285+03:00 Version: 0.9.90                            topics="status-app" tid=13320404 file=nim_status_client.nim:189
INF 2023-09-11 13:18:11.285+03:00 Commit: 2d84e2a13                          topics="status-app" tid=13320404 file=nim_status_client.nim:190
INF 2023-09-11 13:18:11.285+03:00 Current date:                              topics="status-app" tid=13320404 file=nim_status_client.nim:191 currentDateTime=2023-09-11T13:18:11+03:00
INF 2023-09-11 13:18:11.285+03:00 starting application controller...         topics="status-app" tid=13320404 file=nim_status_client.nim:193
INF 2023-09-11 13:18:11.853+03:00 starting application...                    topics="status-app" tid=13320404 file=nim_status_client.nim:196
WRN 2023-09-11 13:18:11.857+03:00 Error decoding signal                      topics="signals-manager" tid=13320404 file=signals_manager.nim:43 err="Unknown signal received: mediaserver.started"
Debug: StatusApplicationDelegate::applicationDidFinishLaunching (:0, )
Debug: needed to resize (:0, )
Debug: size:  0 , new size:  8294400 (:0, )
WARN [09-11|13:20:51.641] failed to connect to any of given addresses. Retrying... error="failed to connect to any of given addresses. connecting to 'https://10.77.128.175:51086' failed: dial tcp 10.77.128.175:51086: connect: operation timed out; "
WARN [09-11|13:22:07.646] failed to connect to any of given addresses. Retrying... error="failed to connect to any of given addresses. connecting to 'https://10.77.128.175:51086' failed: dial tcp 10.77.128.175:51086: connect: operation timed out; "

@saledjenic
Copy link
Contributor Author

@qfrank seems that the status-go changes are not compatible with the desktop app?
The desktop app doesn't work if it points to that status-go PR. Do we need to apply anything on the desktop app side or?

@saledjenic
Copy link
Contributor Author

@alaibe we have a request from the mobile team ( @churik ) to include the related status-go PR to the 0.14. release once the issue @anastasiyaig found gets fixed.

@qfrank
Copy link

qfrank commented Sep 11, 2023

Hi @anastasiyaig , i guess the stuck will get through finally right, it just take seconds?

@saledjenic
Copy link
Contributor Author

@qfrank @anastasiyaig I've just created another PR, here: #12121

it is made from desktop master 61f3d903ce437b97f7509e173dc18012b08e340e and points to statusgo e77fc59f5e13877c5d62e58213cd12ba88415939

and this PR is updated and it's now made from 61f3d903ce437b97f7509e173dc18012b08e340e and points to statusgo 9c6519c00218d3da8f0e9bfbaa53d539cb83d023

@anastasiyaig
Copy link
Contributor

I added a separate issue to the problem discussed #12126 to fix it later

@saledjenic
Copy link
Contributor Author

@anastasiyaig @qfrank I wouldn't say that's an issue on the desktop app side, I would rather say that's something recently changed/updated on the status-go side.

@igor-sirotin
Copy link
Contributor

@saledjenic I believe the base branch should be release/0.14.x, right?

@saledjenic
Copy link
Contributor Author

@igor-sirotin have no idea, if the issue is reproducible in master I guess you can fix it there.

@igor-sirotin
Copy link
Contributor

I'd say that this PR is simply an update to pick up status-go changes, i.e. #12111. If this PR is the reason for #12126, I will fix it first ofc, but the destination branch should be 0.14.x anyway.

Let me know if you have any objections with that :)

@igor-sirotin igor-sirotin changed the base branch from master to release/0.14.x September 13, 2023 12:43
@igor-sirotin
Copy link
Contributor

Changed the base branch, will rebase soon.

@status-im-auto
Copy link
Member

@igor-sirotin
Copy link
Contributor

Rebased.
Here's a status-go PR to cherry-pick the changes to desktop release: status-im/status-go#4023

@igor-sirotin
Copy link
Contributor

Closing, as status-go is already pointing above status-im/status-go#4010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick status-go PR#4010 to release 0.14
8 participants