-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check the status-go PR changes that fix #17223 mobile issue against the desktop app #12117
Conversation
Jenkins BuildsClick to see older builds (20)
|
alright, i will take a look @saledjenic |
Thank you, results are status-im/status-mobile#17226 (comment) |
@saledjenic i noticed that the desktop app is stuck when u scan a QR code from mobile device. How to reproduce:
Console log:
|
@qfrank seems that the status-go changes are not compatible with the desktop app? |
@alaibe we have a request from the mobile team ( @churik ) to include the related status-go PR to the 0.14. release once the issue @anastasiyaig found gets fixed. |
Hi @anastasiyaig , i guess the stuck will get through finally right, it just take seconds? |
2d84e2a
to
39a5321
Compare
@qfrank @anastasiyaig I've just created another PR, here: #12121 it is made from desktop master and this PR is updated and it's now made from |
I added a separate issue to the problem discussed #12126 to fix it later |
@anastasiyaig @qfrank I wouldn't say that's an issue on the desktop app side, I would rather say that's something recently changed/updated on the status-go side. |
@saledjenic I believe the base branch should be |
@igor-sirotin have no idea, if the issue is reproducible in master I guess you can fix it there. |
Changed the base branch, will rebase soon. |
✔️ status-desktop/branches/linux/x86_64/tests-nim/PR-12117#3 🔹 ~6 min 23 sec 🔹 39a5321 🔹 📦 tests/nim package |
0b34c68
to
f42899c
Compare
Rebased. |
Closing, as status-go is already pointing above status-im/status-go#4010. |
Closes #12111
@qa please do check the syncing feature in this PR which points to the changes of the status-go that fix mobile issue: