-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sync is hanging in "syncing devices" stage #17226
Conversation
1510246
to
4812cc0
Compare
Jenkins BuildsClick to see older builds (12)
|
Hi @qfrank thank you for PR. Did I understand correctly, that this PR does not currently resolve the syncing issue and it only resolves the problem of the app getting stuck when the 'try again' button is tapped? However, a new issue has been introduced. After scanning the QR code on Android, the 'Syncing device' stage doesn't hang anymore, but now there's an issue where the scan section is displayed without a QR code inside the scan area after the QR code has been scanned. Actual result:the scan section is displayed without a QR code inside the scan area after the QR code has been scanned. (for at least 5 seconds) scan3.mp4Expected result:The 'Oops something went wrong' page is shown as soon as the QR is scanned EnvDesktop 0.14.0, rc4 logs: |
For me still stuck on the same stage: |
79% of end-end tests have passed
Failed tests (9)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
I thought this should be fixed at least, but i missed another cert generation, will make an update soon. |
Apologies for the inconvenience. Please try again when you have a moment. @churik |
Looks like "retry connections" not work for @VolodLytvynenko (no route to host), any ideas(i've checked network detail from @VolodLytvynenko before, seems good to me)? cc @Samyoul @cammellos |
@qfrank still the same unfortunately |
Upon further consideration, I believe the desktop application will also need to be updated along with my status-go PR in order to fully resolve this issue. Since the desktop app plays the role of generating the certificate in this case, it seems including the changes from my PR on the desktop side as well is necessary to produce the expected behavior. @churik cc @igor-sirotin |
update: I've asked @saledjenic (thanks to @saledjenic !) to create a desktop PR to include my status-go PR, so you can retry cc @churik |
@qfrank @saledjenic can you point me to the PR? |
@saledjenic will tag us when it's ready
|
Regarding to @VolodLytvynenko 's issue (different issue from @churik faced,
the result of |
@churik @qfrank here is a PR: |
tested builds with IOS and Android, works fine now. @saledjenic can you please make sure this commit will be included to 0.14? Thank you! |
@churik when desktop app QAs confirm we can merge the status-go PR to status-go develop branch, I will ensure that the desktop app master includes it. @churik I guess you meant to 0.15.0? That should be the next desktop app release version. |
@saledjenic I meant 0.14, which is in RC now, otherwise we got incompatible builds from mobile and desktop. Thank you! |
Hmm, that is frustrating @qfrank. We need to build out some better debugging tools for these kind of issues. I opened I notice that the desktop is pinging @VolodLytvynenko which device is producing the QR code, desktop or mobile? Do you know if the android device can ping |
@VolodLytvynenko I can see in this comment #17226 (comment) it is the desktop that generates the QR code. |
Hi @Samyoul , thanks for your reply, FYI, |
ca1b106
to
7d056ff
Compare
7d056ff
to
dc0bc34
Compare
79% of end-end tests have passed
Failed tests (9)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
|
fixes #17223
status: ready