Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteMultiaccount method #2001

Merged
merged 1 commit into from
Jul 14, 2020
Merged

DeleteMultiaccount method #2001

merged 1 commit into from
Jul 14, 2020

Conversation

rasom
Copy link
Collaborator

@rasom rasom commented Jul 13, 2020

@rasom rasom self-assigned this Jul 13, 2020
@ghost
Copy link

ghost commented Jul 13, 2020

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jul 13, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 2eb2c5d #1 2020-07-13 10:48:30 ~1 min linux 📄log
❌ 2eb2c5d #1 2020-07-13 10:48:58 ~1 min ios 📄log
❌ 2eb2c5d #1 2020-07-13 10:49:06 ~2 min android 📄log
❌ 7c73892 #2 2020-07-13 10:51:34 ~24 sec ios 📄log
❌ 7c73892 #2 2020-07-13 10:52:04 ~53 sec linux 📄log
❌ 7c73892 #2 2020-07-13 10:52:57 ~1 min android 📄log
❌ 498fb5e #3 2020-07-13 11:18:53 ~1 min linux 📄log
❌ 498fb5e #3 2020-07-13 11:18:58 ~1 min ios 📄log
❌ 498fb5e #3 2020-07-13 11:19:17 ~2 min android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ c0a00b2 #4 2020-07-13 12:15:07 ~28 sec ios 📄log
❌ c0a00b2 #4 2020-07-13 12:15:36 ~55 sec linux 📄log
❌ c0a00b2 #4 2020-07-13 12:16:17 ~1 min android 📄log
✔️ 0b3cdf7 #5 2020-07-13 13:22:54 ~2 min linux 📦zip
✔️ 0b3cdf7 #5 2020-07-13 13:24:33 ~3 min ios 📦zip
✔️ 0b3cdf7 #5 2020-07-13 13:27:48 ~7 min android 📦aar

@rasom rasom requested review from Samyoul and cammellos July 13, 2020 11:10
cammellos
cammellos approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@cammellos cammellos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of minor comments

api/backend_test.go Show resolved Hide resolved
api/geth_backend.go Outdated Show resolved Hide resolved
@rasom rasom force-pushed the delete-multiaccount branch from 498fb5e to c0a00b2 Compare July 13, 2020 12:14
@rasom rasom force-pushed the delete-multiaccount branch from c0a00b2 to 0b3cdf7 Compare July 13, 2020 13:20
@rasom rasom merged commit 0b3cdf7 into develop Jul 14, 2020
@rasom rasom deleted the delete-multiaccount branch July 14, 2020 07:32
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@Samyoul Samyoul Awaiting requested review from Samyoul

Assignees

@rasom rasom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasom @status-im-auto @cammellos