Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delete multiaccount #10195

Closed
hesterbruikman opened this issue Mar 23, 2020 · 2 comments · Fixed by #10955
Closed

Allow delete multiaccount #10195

hesterbruikman opened this issue Mar 23, 2020 · 2 comments · Fixed by #10955
Assignees

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Mar 23, 2020

Problem

Allow removing a multiaccount. This feature will be required to introduce moving an existing regular multiaccount to Keycard. Maintaining the multiaccount on local storage (keys on phone) would nullify the security Keycard brings.

We have also received this feature request multiple times. Although it is not entirely clear why people ask for this feature, opposed to uninstalling the app, it makes sense to want to have a sense of security by being able to remove data.

Implementation

  1. Add list item in Settings > Privacy and security
  • Add popover dialog for confirmation
  • Remove keys and any additional data from database
  • If user does not have other multiaccounts:
    Open first screen of onboarding
  • If user does have other multiaccounts
    Open Your keys
  1. Add remove action on Your keys
  • Longpress action on list item
  • Show bottom sheet Delete profile - similarly to Delete chat

Acceptance Criteria

Implementation follows design (to be added)

Notes

Future Steps

@hesterbruikman
Copy link
Contributor Author

cc @rachelhamlin @guylouis

@guylouis
Copy link
Contributor

This is needed also to be able to reset a keycard (clean it from from his secrets), since once it is cleared we need to remove the multiaccount from Status UX

See roman comment here #9229 (comment)

@rasom rasom self-assigned this Jun 16, 2020
rasom added a commit that referenced this issue Jun 18, 2020
Having all keys related to specific multiacc in a
separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to
different multiaccs.
rasom added a commit that referenced this issue Jun 22, 2020
Having all keys related to specific multiacc in a
separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to
different multiaccs.
rasom added a commit that referenced this issue Jun 23, 2020
Having all keys related to specific multiacc in a
separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to
different multiaccs.
rasom added a commit that referenced this issue Jun 24, 2020
Having all keys related to specific multiacc in a
separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to
different multiaccs.
rasom added a commit that referenced this issue Jun 24, 2020
Having all keys related to specific multiacc in a
separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to
different multiaccs.
rasom added a commit that referenced this issue Jun 24, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jun 24, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 1, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 2, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 6, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 6, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 7, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 8, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 9, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 9, 2020
Having all keys related to specific multiacc in a separate dir will
simplify removing of the multiacc. Also it will allow adding of the same
account to different multiaccs.
rasom added a commit that referenced this issue Jul 14, 2020
rasom added a commit that referenced this issue Jul 14, 2020
rasom added a commit that referenced this issue Jul 16, 2020
rasom added a commit that referenced this issue Jul 24, 2020
rasom added a commit that referenced this issue Jul 24, 2020
rasom added a commit that referenced this issue Jul 24, 2020
rasom added a commit that referenced this issue Jul 25, 2020
rasom added a commit that referenced this issue Jul 28, 2020
rasom added a commit that referenced this issue Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants