Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(onboarding)_: enable creating accounts without a displayName #6242

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jrainville
Copy link
Member

The new onboarding flows let users create accounts without a display name to simplify the flows.

@status-im-auto
Copy link
Member

status-im-auto commented Jan 9, 2025

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b525faa #1 2025-01-09 20:34:59 ~3 min macos 📦zip
✔️ b525faa #1 2025-01-09 20:35:35 ~4 min ios 📦zip
✔️ b525faa #1 2025-01-09 20:36:45 ~5 min windows 📦zip
✔️ b525faa #1 2025-01-09 20:36:47 ~5 min android 📦aar
✔️ b525faa #1 2025-01-09 20:36:52 ~5 min linux 📦zip
✔️ b525faa #1 2025-01-09 20:38:16 ~6 min tests-rpc 📄log
✔️ b525faa #1 2025-01-09 20:44:21 ~13 min macos 📦zip
✔️ b525faa #1 2025-01-09 21:02:23 ~31 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e446e61 #2 2025-01-14 14:39:39 ~4 min windows 📦zip
✔️ e446e61 #2 2025-01-14 14:40:26 ~5 min macos 📦zip
✔️ e446e61 #2 2025-01-14 14:41:03 ~5 min linux 📦zip
✔️ e446e61 #2 2025-01-14 14:41:18 ~6 min android 📦aar
✔️ e446e61 #2 2025-01-14 14:41:59 ~6 min tests-rpc 📄log
✔️ e446e61 #2 2025-01-14 14:42:30 ~7 min macos 📦zip
✔️ e446e61 #2 2025-01-14 15:06:27 ~31 min tests 📄log
✔️ e446e61 #2 2025-01-15 07:05:16 ~16 hr ios 📦zip
✔️ cf3c5ca #3 2025-01-21 14:45:45 ~3 min macos 📦zip
✔️ cf3c5ca #3 2025-01-21 14:46:05 ~3 min ios 📦zip
✔️ cf3c5ca #3 2025-01-21 14:47:47 ~5 min windows 📦zip
✔️ cf3c5ca #3 2025-01-21 14:47:54 ~5 min linux 📦zip
✔️ cf3c5ca #3 2025-01-21 14:48:14 ~5 min macos 📦zip
✔️ cf3c5ca #3 2025-01-21 14:48:30 ~6 min android 📦aar
✔️ cf3c5ca #3 2025-01-21 14:48:47 ~6 min tests-rpc 📄log
✔️ cf3c5ca #3 2025-01-21 15:13:13 ~30 min tests 📄log

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.76%. Comparing base (69855f2) to head (cf3c5ca).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6242      +/-   ##
===========================================
+ Coverage    61.75%   61.76%   +0.01%     
===========================================
  Files          843      843              
  Lines       111285   111285              
===========================================
+ Hits         68720    68735      +15     
+ Misses       34592    34579      -13     
+ Partials      7973     7971       -2     
Flag Coverage Δ
functional 21.56% <100.00%> (+0.10%) ⬆️
unit 60.28% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/geth_backend.go 54.23% <100.00%> (ø)
mobile/status.go 9.74% <100.00%> (ø)

... and 30 files with indirect coverage changes

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, what a simple change 😏

@jrainville
Copy link
Member Author

@osmaczko friendly reminder to review

@jrainville jrainville merged commit 3e0b1b2 into develop Jan 21, 2025
19 checks passed
@jrainville jrainville deleted the feat/new-onbaording branch January 21, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants