Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean keycard and remove multi-account #9229

Closed
guylouis opened this issue Oct 16, 2019 · 9 comments · Fixed by #11803
Closed

Clean keycard and remove multi-account #9229

guylouis opened this issue Oct 16, 2019 · 9 comments · Fixed by #11803
Assignees
Labels
feature feature requests
Milestone

Comments

@guylouis
Copy link
Contributor

guylouis commented Oct 16, 2019

Situation

Currently, after a keycard has been set-up after onboarding the keycard has

  • setup a PIN, Pairing code, PUK
  • secrets loaded (which correspond to status multiaccount seed)

Problem

There is no possibility for the user to remove the secrets loaded physically from the card

A user might want to delete the secrets from his card because

  • despite the high level of hardware security of his card, he wants to remove them physically from there to prevent any attack to succeed now or later
  • he wants to change the multiaccount on his card

Solution

A simple approach would be

  • user is logged in his keycard multiaccount
  • user goes to 'settings/keycard'
  • user choses 'reset keycard' (to be added, does not exist today)
  • user is prompted
    "You're about to delete the keys on this card, your pairing code/PUK & PIN remain will unchanged.
    You must have your seed if you want to recover any funds from this key in the future. You can now restore another key on this card. Your Pairing code remains unchanged and will be needed if you use a new phone.
    Are you sure you want to proceed ? yes/no"
  • if the user clicks 'yes' then
    - we leaves PIN, PUK, Pairing uncode untouched on the card
    - the secret on the card is deleted
    - the multiaccount is removed from the phone
@3esmit
Copy link
Member

3esmit commented Oct 17, 2019

If user forgets Pairing code, PUK and/or PIN, it should be able to reset?

@guylouis
Copy link
Contributor Author

given the low value ($) of the card it self we've not designed it this way ...
the user must remember his PIN (or PUK) to access his card, and he must remember his pairing if he has no phone paired

If we implement #9064 after v1, the user will be able to recover any keycard if he has his seed (and if PUK/Pairing hasn't been changed form the derived version of the seed by another app...)

@rasom
Copy link
Contributor

rasom commented Nov 11, 2019

Keycard's side of this task is already implemented, so we need to make sure that there is an API for multiacc removal.

@guylouis
Copy link
Contributor Author

guylouis commented Nov 12, 2019 via email

rasom added a commit to rasom/status-go that referenced this issue Nov 12, 2019
DeleteAccount method is added, it deletes account from
multiaccounts database and also removes account's DB file.
The method is needed for keycard reseting functionality.
status-im/status-mobile#9229
rasom added a commit to rasom/status-go that referenced this issue Nov 12, 2019
DeleteAccount method is added, it deletes account from
multiaccounts database and also removes account's DB file.
The method is needed for keycard reseting functionality.
status-im/status-mobile#9229
rasom added a commit to rasom/status-go that referenced this issue Nov 12, 2019
DeleteAccount method is added, it deletes account from
multiaccounts database and also removes account's DB file.
The method is needed for keycard reseting functionality.
status-im/status-mobile#9229
@StatusWrike StatusWrike changed the title Add a 'reset keycard' feature Add a 'reset keycard' feature Nov 18, 2019
@cammellos
Copy link
Contributor

@errorists @hesterbruikman could you please have a look at the UI for this?
Thanks

@guylouis
Copy link
Contributor Author

would be great to progress on this
@johnlea-quiup
wdyt about the UX ?

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Oct 29, 2020

Wondering if this could be captured under 'Delete my profile' for consistency with regular multiaccounts. Result would be more or less this:

Frame 222
Figma

@guylouis
Copy link
Contributor Author

guylouis commented Nov 3, 2020

fully agree with you @hesterbruikman

@guylouis
Copy link
Contributor Author

guylouis commented Nov 6, 2020

So this issue #9229 is flow 6 of this figma design https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=8197%3A858

@guylouis guylouis changed the title Add a 'reset keycard' feature Clean keycard and remove multi-account Nov 6, 2020
@guylouis guylouis added this to the Release 1.13 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants