Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is shown in English instead of device language for some languages #8718

Closed
churik opened this issue Aug 7, 2019 · 10 comments · Fixed by #9286
Closed

App is shown in English instead of device language for some languages #8718

churik opened this issue Aug 7, 2019 · 10 comments · Fixed by #9286
Assignees

Comments

@churik
Copy link
Member

churik commented Aug 7, 2019

Description

Type: Bug
Summary: for some languages (translations are presented in https://github.com/status-im/status-react/tree/develop/translations) app is still shown in English after setting device language. Randomly checked several languages - all fine with Russian\Korean (so device settings are applied to app language), but not with French, Vietnamese, Danish.
Reproducible on 0.13.0 and later.

Expected behavior

app language is changed

Actual behavior

app is still in English

Reproduction

  • Change your phone language to French, Vietnamese or Danish
  • Open Status app and check language

Additional Information

  • Status version: release 0.13.0, nightly 07/08/2019
  • Operating System: Android, iOS
@churik churik added bug labels Aug 7, 2019
@annadanchenko
Copy link

when fixed, please make sure that in addition to the listed problematic languages we test with other languages not mentioned in the initial bug description (so not Korean, Russian, French, Vietnamese and Danish)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Oct 21, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 week, 3 days from now.
Please review their action plans below:

1) alphaserpentis has been approved to start work.

I would reproduce the bug as described and observe the result. Then, I will begin research on the subject and review the code as to where things could be acting up.

Device: iPhone 8 - iOS (Public Release Latest)
Reproducibility: Easily reproduced

Learn more on the Gitcoin Issue Details page.

@StatusSceptre
Copy link
Member

Hey @AlphaSerpentis, wonderful. Welcome to the project! Let us know if you need any support.

@StatusSceptre StatusSceptre self-assigned this Oct 22, 2019
@AlphaSerpentis
Copy link
Contributor

AlphaSerpentis commented Oct 22, 2019 via email

@AlphaSerpentis
Copy link
Contributor

AlphaSerpentis commented Oct 22, 2019

I cannot install the test build, do I need my device's UDID provisioned?

If so, here's the UDID: 7d72aeaaf0935466e247ac640f7b6f77287456a4

@StatusSceptre

AlphaSerpentis added a commit to AlphaSerpentis/status-react that referenced this issue Oct 25, 2019
* Update fr.json

Validated JSON file (last line contained an extra comma)

* Update i18n_resources.cljs

Defined the languages and translations
@StatusSceptre
Copy link
Member

Hey @AlphaSerpentis - I apologize for missing this! On Status, we can communicate in #status-core or you can ping me, Rachel, at 0x04d6d9f89df553eaf338dbd66ffd8c256c4f45042ee5460be28d9d77933ad6d59b6f1554e2075f5b130d556e1957715a03b8447bfacad951910184243a96a9a8b8.

Do you still need help getting set up?

@AlphaSerpentis
Copy link
Contributor

Hey @AlphaSerpentis - I apologize for missing this! On Status, we can communicate in #status-core or you can ping me, Rachel, at 0x04d6d9f89df553eaf338dbd66ffd8c256c4f45042ee5460be28d9d77933ad6d59b6f1554e2075f5b130d556e1957715a03b8447bfacad951910184243a96a9a8b8.

Do you still need help getting set up?

I just need someone to review if the code actually works.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

  1. @alphaserpentis

@StatusSceptre please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @AlphaSerpentis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants