getGasPrice can return 0 #6505
Comments
|
Tried this out in local and it doesn't look like a good idea any more. What happens is that if 0 is silently replaced by 1 wei, then the transaction is also going to fail (e.g. on xdai 1 gwei looks like a good gas cost at the moment), but the reason for it is obscured by the replacement. |
|
have same issue (default Gas price is 0 Gwei) on #7407 |
|
This is particularly important for networks like xdai which don’t have an api to pull gas estimates |
|
@goranjovic can we put a bounty on this? When trying to send XDAI or any other assets on the XDAI network I have to manually set a gas price. No Bueno. Maybe we either hardcode or implement an alternative that's better maybe with https://blockscout.com ? LMK what you think.
|
|
@goranjovic any thoughts here? |
|
@goranjovic do you still want a bounty for this? |
|
@StatusSceptre yes, let's do that. Size S seems appropriate |
|
k |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.
|
|
@ab320012 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
|
Hmm. As previously seen in the discussion - Price 1 sometimes causes problems aswell - is there any API we could query instead that would give us a "valid 24h gas price" for example, or just a wild guess in the range within the last 24-48h? We could also just set a default value of like... 3-5 gwei, and add a user setting to override a default whenever 0 is returned or the gas service is unreachable? Maybe add an alternative gas service somewhere in the settings aswell? ... or do we have access to transaction history? If so, we could use the gas-gwei from the last transaction per default. |
|
Is this issue still open? |
|
@rachelhamlin wdyt? Not sure where this falls these days tbh. |
|
Happy to have this fixed if possible!
…On Tue, May 28, 2019 at 6:13 PM StatusSceptre ***@***.***> wrote:
@rachelhamlin <https://github.com/rachelhamlin> wdyt? Not sure where this
falls these days tbh.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6505>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADWA6YZRAKSKZAHPSXZ5JNDPXVR2NANCNFSM4F655RFQ>
.
|
|
ok @janus @kuhnchris feel free to apply on Gitcoin then - work is stopped, so you should be able to. |
|
I'll let @janus try for now, if he cannot manage to pull through I may aswell join in. ;-) Thanks, |
|
@goranjovic Accept by expression if you still want this to be tackled |
|
Thanks @janus - sorry about the delay! @StatusSceptre can we approve @janus? |
|
What's up with this issue? I'd like to give it a shot if possible. |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 10 months, 2 weeks ago. 1) krisc has applied to start work (Funders only: approve worker | reject worker). Will begin by reproducing the unwanted behavior then modify the code to implement the expected behavior. https://www.notion.so/Privacy-Policy-e7f23fb15ece4cf5b0586f9629e08b3f Learn more on the Gitcoin Issue Details page. |
|
@krisc hey there! Thank you for applying. From my perspective, this is a rather low priority. What is it that interests you about this issue? We have a backlog of more pressing items & I might suggest that we scan that for a match for your skills, and create a new bounty for you instead. :) |
|
@rachelhamlin I just browsed through open bounties for Status in the Gitcoin explorer. I wanted to work on this one as a way to warm up to the Status codebase since haven't worked on Status for a couple months. Is there a way for me to browse through issues by priority? |
Please I have free time and would like to get involved in your pressing items. Where is the list of pressing items? |
I have some Clojure skill and a bit of go. But I am not greatly involved in React Native. I use only Android phones. You did not indicate the OS of interest. |
|
All issues in status-react are for iOS & Android, RN mobile @janus :) We will manually test bounty PRs on multiple devices. Here's our quick start for getting set up: https://status.im/build_status/status_react_quickstart.html |
|
@rachelhamlin thanks for posting those issues. Can we chat in Status? Here's my contact code: |
|
@churik I can't reproduce this issue, but it might still be relevant and important as some projects are moving to xdai. cc @richard-ramos for any insight on how gas estimation might be handled on xDai |
|
I can't reproduce it consitantly as well, I saw it few times in e2e when gas price was calculated on Ropsten. |
|
Igor Barinov from POA/XDai says:
so, probably returning 1 gwei as default for xdai if price is not available is the way to go? |
|
Issue is not reproducible on release 1.13 |
User Story
As a user I want useful default gas price settings on all networks when I send transactions.
Description
Type: Bug
Summary: For some reason, on xDAI chain
getGasPricesometimes gives 0 as the result (openethereum/parity-ethereum#9795). This means that the default gas price in Send Transaction screen is going to be 0 and unless user changes that value manually, that transaction is always going to fail.We should include a sentinel value of 1 wei either in the enclosing wrapper function in
status-reactwhen the underlying web3 function gives a 0 result. (Or alternatively, changegetGasPriceto include the same logic on thestatus-goside.Issue was originally found in PR #6388 - point 6
Expected behavior
Default gas price is never 0.
Actual behavior
Default gas price is sometimes 0 on xDAI chain.
Reproduction
The text was updated successfully, but these errors were encountered: