-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Back, swipe-to-the-left and hardware device Back buttons to align the behavior #8940
Comments
whew, ok here goes nothing :)
It's not a cancel action, but then again it would depend I guess on what you mean by cancel. It's like hitting the back button in your internet browser, if you loose data you had in that page then you might think of it as a cancel. Now the Android back button, I have no clue really as I don't use an Android phone 😁 By Google's definition it does the same thing as the in-app Back <-/X so it's a duplicate. On newer devices it's replaced with a edge swipe gesture just like iOS. There are areas like the browser where we could point the software button to go backward to the previous page rather than exiting the webview. In any case, it should act as similar as humanly possible to any natively written app. All of the issues you point to sound like implementation errors when dealing with React Navigation i.e. wrongly linked screens. |
I'd like to ask, because I might've missed some thread, what's the expectation of us, should we create documentation for what happens when you press back/swipe/hit device back button on each and every screen? |
Two things I'd like to add to what Maciej just said:
|
So I think what can be done now is:
All exceptions, like the one I've mentioned above (skipping the "Join public chat" screen), are unique and context-specific and require discussion and testing. |
the first step of navigation improvement, for v1 we want to avoid broken app states, so i added a list of views there it's possible to navigate back safely, we can remove v1 label and continue improvements after v1 |
@flexsurfer I'll go ahead and ask you here, would it be possible for the navigation to work like below, so currently if you navigate back from a |
@errorists yes it's possible |
@flexsurfer you're awesome, thanks for the quick reply |
…tons to align the behavior Signed-off-by: Andrey Shovkoplyas <[email protected]>
Problem
We have a lot of discrepancies between the following actions across all the application:
What we need to achieve:
This will resolve the following existing issues and prevent new ones:
@andmironov @hesterbruikman @errorists i need your input here since it is a design question anyway.
@rachelhamlin
The text was updated successfully, but these errors were encountered: