Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless processing spinner after entering wrong PIN when signing message from DApp #9206

Closed
churik opened this issue Oct 14, 2019 · 3 comments · Fixed by #9414
Closed

Endless processing spinner after entering wrong PIN when signing message from DApp #9206

churik opened this issue Oct 14, 2019 · 3 comments · Fixed by #9414

Comments

@churik
Copy link
Member

churik commented Oct 14, 2019

Bug Report

Problem

If you enter wrong PIN instead of validation error endless "Processing" spinner is shown.
Also translation is missing on signing screen.
miss

Expected behavior

validation error, can enter valid PIN

Actual behavior

proc_s

Notes

For the developer who will be investigating. Is it related to another PR? Tips on where to start?

Acceptance Criteria

Rules for the future PR to be accepted.

Reproduction

  • Open Status
  • Login with KeyCard
  • Open status-im.github.io/dapp > Transaction > Sign message
  • Enter wrong PIN-code > sign in

Additional Information

  • Status version: nightly 14/11/2019
  • Operating System: Android

Logs

Full logcat: logcat.log

@guylouis
Copy link
Contributor

guylouis commented Nov 6, 2019

@churik
hey Chu ! I am curious about what you think of the criticity of this one? if right PIN is entered, then everything is ok and if it's a wrong PIN the app needs to be killed right ?

@churik
Copy link
Member Author

churik commented Nov 6, 2019

Yes, I believe it should be fixed - just to display validation error.
I think that it should be done in v1 scope.

@rasom rasom assigned rasom and unassigned rasom Nov 7, 2019
@rasom
Copy link
Contributor

rasom commented Nov 7, 2019

My both keycards are dead, that's why can't work on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants