Reset Keycard functionality #11803
Merged
Reset Keycard functionality #11803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (21)
|
bitgamma
changed the title
96% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (77)Click to expand |
97% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (75)Click to expand
|
100% of end-end tests have passedPassed tests (2)Click to expand
|
rasom
reviewed
Mar 2, 2021
| @@ -74,6 +39,6 @@ | |||
| :puk [] | |||
| :status nil | |||
| :error-label nil | |||
| :on-verified :keycard/remove-key-with-unpair})} | |||
| :on-verified (if keep-keys-on-keycard? :keycard/unpair-and-delete :keycard/remove-key-with-unpair)})} | |||
There was a problem hiding this comment.
Could you please make it three lines expression? It won't fit 80 chars anyway but this way it is too long
There was a problem hiding this comment.
Done. Thanks for the review!
rasom
approved these changes
Mar 2, 2021
|
@bitgamma Thank you for the great work! Testing is still ongoing. ISSUE 1: No message "2 attempts left" when entering invalid passcode (PIN) during profile deleting. Android onlyReproduction
Expected behaviorMessage about how many attempts are left for each input of an incorrect PIN ("2 attempts left", "1 attempt left") Actual behaviorNo messages. The PIN screen is closed just after entering an invalid PIN and tapping the keycard video_2021-03-03_14-19-41.mp4 |
|
@qoqobolo Thanks for the report! Is there any particular prerequisite to reproduce this? I tried on a OnePlus 6 and Xiaomi Redmi Note 8T (both Android 10), and I cannot reproduce it, the number of remaining attempts is shown correctly. |
@bitgamma hmm.. Well, now I can't reproduce it too. My test device is Google Pixel 2 (Android 11). |
ISSUE 2/QUESTION: Can't use keycard after reset.@bitgamma But when I try to generate a new multiaccount after reset and choose my card as key storage, after getting a new seed phrase, I am asked to confirm my passcode and after I get this message: Steps:
video_2021-03-03_17-26-06.mp4Also, I get the same screen and pop-up if I try to restore my multi-account with seed phrase and chose key storage on my keycard. Steps:
video_2021-03-03_17-28-45.mp4If I go through the third flow and try to recover my multiaccount with keycard I get this screen Could you clarify if this behavior is expected (the first two cases)? |
|
@qoqobolo Thanks a lot for catching this! Your assumption are absolutely correct, you should be able to load a new account or enter an existing seed. If you restart Status it works, but if you try to create a new account immediately after deleting it doesn't. I will fix this and ping you. |
|
@qoqobolo issue 2 is fixed now |
|
@bitgamma could you rebase this to the latest develop, please? |
bitgamma
force-pushed
the
feature/reset-keycard
branch
from
64103d1 to
094e0a1
Compare
93% of end-end tests have passedFailed tests (11)Click to expand
Passed tests (148)Click to expand
|
|
@bitgamma thanks for the great work! |
bitgamma
force-pushed
the
feature/reset-keycard
branch
from
094e0a1 to
de847d8
Compare
Signed-off-by: Michele Balistreri <[email protected]>
bitgamma
force-pushed
the
feature/reset-keycard
branch
from
de847d8 to
5fecdd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Keycard account removal with (optional) card reset.
Closes #9229
Screenshot with highlighted new strings for localization
status: ready