Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mentions on edited message #14093

Closed
wants to merge 1 commit into from
Closed

Fix mentions on edited message #14093

wants to merge 1 commit into from

Conversation

audriu
Copy link
Contributor

@audriu audriu commented Sep 30, 2022 •
edited
Loading

fixes #14051

Summary

Fixes edited messages mentions

Platforms

  • Android
  • iOS
Functional
  • 1-1 chat
  • public chats
  • group chats
  • account recovery
  • new account
  • user profile updates

Steps to test

  • Open Status
  • Send messages that mention other users (with and without ENS usernames)
  • Edit those messages
  • See if edited messages with ENS name are displayed correctly
  • Also check if anywhere username is mentioned is displayed correctly
  • Have a nice day

status: ready

@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from 5e10942 to 18f365a Compare September 30, 2022 13:45
@audriu audriu self-assigned this Sep 30, 2022
@audriu audriu requested a review from a team September 30, 2022 14:00
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from 18f365a to 191cbc3 Compare September 30, 2022 14:47
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from 191cbc3 to b9d398b Compare September 30, 2022 17:09
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from b9d398b to c581d47 Compare October 3, 2022 07:18
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch 2 times, most recently from 94e7793 to afc4b5a Compare October 3, 2022 09:23
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch 2 times, most recently from 65336f6 to 9e65fc9 Compare October 3, 2022 10:43
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from 9e65fc9 to ab20ba8 Compare October 3, 2022 10:53
@Parveshdhull
Copy link
Member

Issue is still not fixed

main.mp4

@audriu audriu marked this pull request as draft October 3, 2022 11:15
@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from ab20ba8 to 36cf9a2 Compare October 3, 2022 12:56
@audriu audriu requested a review from Parveshdhull October 3, 2022 12:57
@Parveshdhull
Copy link
Member

Hi @audriu thank you for the changes, there is still an issue in the PR, on editing message mention is getting lost.

(Please smoke test functionality, before requesting review and manual testing)

main.mp4

@audriu
Copy link
Contributor Author

audriu commented Oct 3, 2022

I tested on 121 chat. but forgot the group chat. Well spotted Parvesh

@audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from b6ada55 to e976209 Compare October 3, 2022 18:26
@status-im-auto
Copy link
Member

✔️ status-mobile/prs/tests/PR-14093#14 🔹 ~1 min 53 sec 🔹 e976209 🔹 📦 tests package

@status-im-auto
Copy link
Member

✔️ status-mobile/prs/android/PR-14093#14 🔹 ~7 min 57 sec 🔹 e976209 🔹 📦 android package

@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im status-im deleted a comment from status-im-auto Oct 3, 2022
@status-im-auto
Copy link
Member

✔️ status-mobile/prs/android-e2e/PR-14093#14 🔹 ~8 min 38 sec 🔹 e976209 🔹 📦 android e2e package

@status-im-auto
Copy link
Member

✔️ status-mobile/prs/ios/PR-14093#14 🔹 ~16 min 🔹 e976209 🔹 📦 ios package

@status-im status-im deleted a comment from status-im-auto Oct 4, 2022
@status-im status-im deleted a comment from status-im-auto Oct 4, 2022
@status-im status-im deleted a comment from status-im-auto Oct 4, 2022
@status-im-auto
Copy link
Member

57% of end-end tests have passed

Total executed tests: 14
Failed tests: 6
Passed tests: 8

IDs of failed tests: 700767,6253,6265,6263,702186,702153

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Transaction #5, amount is 0.0
    {'blockNumber': '7702665', 'blockHash': '0x90913bc6089bd819e71ff1152dfc62e00cc6e245dccc3f1bd25badbc2149fe30', 'timeStamp': '1664776236', 'hash': '0xfb2bafa4f0cb32268ba8c3e7533668cdad0c7c6a98ae9d05b6009c1cf32ac7f2', 'nonce': '531', 'transactionIndex': '37', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'to': '0x3d6afaa395c31fcd391fe3d562e75fe9e8ec7e6a', 'value': '0', 'gas': '141028', 'gasPrice': '100000015', 'input': '0xa9059cbb0000000000000000000000004fd3192ed50c47f68288dd59936a357c55d7fd77000000000000000000000000000000000000000000000000000142a07ad9b800', 'methodId': '0xa9059cbb', 'functionName': 'transfer(address to, uint256 tokens)', 'contractAddress': '', 'cumulativeGasUsed': '8885604', 'txreceipt_status': '1', 'gasUsed': '117524', 'confirmations': '6064', 'isError': '0'}

    critical/chats/test_1_1_public_chats.py:84: in test_1_1_chat_command_send_tx_eth_outgoing_tx_push
    self.network_api.wait_for_confirmation_of_transaction(self.sender['address'], amount)
../support/api/network_api.py:123: in wait_for_confirmation_of_transaction
    transaction = self.find_transaction_by_unique_amount(address, amount, token)
../support/api/network_api.py:91: in find_transaction_by_unique_amount
    pytest.fail(
 Transaction with amount 0.000464124 is not found in list of ETH transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s



    Device sessions

    2. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Device 1: Double tap on: HomeButton
    Device 1: Find HomeButton by xpath: //*[contains(@content-desc,'tab, 1 out of 5')] 

    critical/chats/test_1_1_public_chats.py:111: in test_1_1_chat_command_decline_eth_push_changing_state
    self.home_1.home_button.double_click()
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    3. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Device 2: Selecting asset(s)
    Device 2: Find Button by accessibility id: accounts-more-options 

    critical/chats/test_1_1_public_chats.py:158: in test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline
    self.wallet_2.select_asset(asset_name)
../views/wallet_view.py:276: in select_asset
    self.multiaccount_more_options.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `accounts-more-options` is not found on the screen



    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Transaction #5, amount is 0.000233611
    {'blockNumber': '7696132', 'blockHash': '0xd8631daf80df6f26448a11a31c9a3332278310fbe7ba3c179001ea4c38a86706', 'timeStamp': '1664681868', 'hash': '0x87ab3dea6f6f457c1f1ae2aec80a33fea15c62202da4a1b64dd48be876dc7fc5', 'nonce': '276', 'transactionIndex': '1', 'from': '0x2836494ad06871443dd56e3108e4dd43a4f449c5', 'to': '0xf18dd7e0a926de61968e024c68ba13a369d4e8b4', 'value': '233611000000000', 'gas': '21000', 'gasPrice': '2100000000', 'input': '0x', 'methodId': '0x', 'functionName': '', 'contractAddress': '', 'cumulativeGasUsed': '179578', 'txreceipt_status': '1', 'gasUsed': '21000', 'confirmations': '12597', 'isError': '0'}

    critical/chats/test_1_1_public_chats.py:698: in test_keycard_command_send_tx_eth_1_1_chat
    self.network_api.wait_for_confirmation_of_transaction(self.sender['address'], amount, confirmations=3)
../support/api/network_api.py:123: in wait_for_confirmation_of_transaction
    transaction = self.find_transaction_by_unique_amount(address, amount, token)
../support/api/network_api.py:91: in find_transaction_by_unique_amount
    pytest.fail(
 Transaction with amount 0.00046455 is not found in list of ETH transactions, address is 2836494ad06871443Dd56e3108E4dD43A4F449c5 during 300s



    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Transaction #5, amount is 0.00033336
    {'blockNumber': '7702096', 'blockHash': '0x33b237da55da090b6e1c243ab181a61d10b623b520e62cb0f8f49b99f46bc968', 'timeStamp': '1664768040', 'hash': '0x0c5dc4c588d859f8263ebcb6508fe05f1c21ea4761a81d3afcd6a926a9c1e739', 'nonce': '291', 'transactionIndex': '39', 'from': '0xb044c703a85251e7044f74ca5099d2d3edd85cdf', 'to': '0x1ee3058bd300246b4b20e687efc9eba81ff7814b', 'value': '333360000000000', 'gas': '21000', 'gasPrice': '110000001', 'input': '0x', 'methodId': '0x', 'functionName': '', 'contractAddress': '', 'cumulativeGasUsed': '6054765', 'txreceipt_status': '1', 'gasUsed': '21000', 'confirmations': '6633', 'isError': '0'}

    critical/chats/test_1_1_public_chats.py:1030: in test_ens_command_send_tx_eth_1_1_chat
    self.network_api.wait_for_confirmation_of_transaction(self.sender['address'], amount, confirmations=3)
../support/api/network_api.py:123: in wait_for_confirmation_of_transaction
    transaction = self.find_transaction_by_unique_amount(address, amount, token)
../support/api/network_api.py:91: in find_transaction_by_unique_amount
    pytest.fail(
 Transaction with amount 0.000464248 is not found in list of ETH transactions, address is b044c703A85251e7044f74Ca5099D2d3EDD85cDf during 300s



    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_send_tx_eth, id: 700767

    Transaction #5, amount is 0.0
    {'blockNumber': '7708048', 'blockHash': '0x7d9c79e667c2b05d7e173a34da79ccfa0e78afa9e4b780a377017c03638ae515', 'timeStamp': '1664855484', 'hash': '0xe3b3754acd1bab49a092255efaae710b3cb95cb58f7d55051517df90654e2366', 'nonce': '1574', 'transactionIndex': '5', 'from': '0x37cd95335b4bff05a3c13a431e0c72359b82811d', 'to': '0x7c9928829641dd2fa76af3408f295a0a116983e3', 'value': '0', 'gas': '150000', 'gasPrice': '2100000001', 'input': '0x', 'methodId': '0x', 'functionName': '', 'contractAddress': '', 'cumulativeGasUsed': '14722995', 'txreceipt_status': '1', 'gasUsed': '102741', 'confirmations': '681', 'isError': '0'}

    critical/wallet_and_tx/test_send_tx_dapp_keycard.py:298: in test_keycard_send_tx_eth
    self.network_api.wait_for_confirmation_of_transaction(self.user['address'], transaction_amount)
../support/api/network_api.py:123: in wait_for_confirmation_of_transaction
    transaction = self.find_transaction_by_unique_amount(address, amount, token)
../support/api/network_api.py:91: in find_transaction_by_unique_amount
    pytest.fail(
 Transaction with amount 0.000465156 is not found in list of ETH transactions, address is 37cd95335b4bFF05A3C13a431e0C72359B82811D during 300s



    Device sessions

    Passed tests (8)

    Click to expand

    Class TestRestoreOneDeviceMerged:

    1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    2. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    2. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    3. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    4. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    @status-im status-im deleted a comment from status-im-auto Oct 4, 2022
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 6
Failed tests: 0
Passed tests: 6

    Passed tests (6)

    Click to expand

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    2. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    3. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_send_tx_eth, id: 700767
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    @audriu audriu force-pushed the 14051-ens-name-turns-into-public-key-after-editing-message-containing-mention-with-this-ens-2 branch from e976209 to 3e3acd5 Compare October 4, 2022 08:32
    @audriu audriu closed this Oct 4, 2022
    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/tests/PR-14093#15 🔹 ~3 min 33 sec 🔹 3e3acd5 🔹 📦 tests package

    @audriu audriu mentioned this pull request Oct 4, 2022
    Closed
    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/android-e2e/PR-14093#15 🔹 ~7 min 11 sec 🔹 3e3acd5 🔹 📦 android e2e package

    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/android/PR-14093#15 🔹 ~8 min 34 sec 🔹 3e3acd5 🔹 📦 android package

    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/ios/PR-14093#15 🔹 ~17 min 🔹 3e3acd5 🔹 📦 ios package

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @audriu audriu

    @pavloburykh pavloburykh

    Labels
    request-manual-qa
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    ENS name turns into public key after editing message containing mention with this ENS
    5 participants
    @audriu @Parveshdhull @status-im-auto @briansztamfater @pavloburykh