-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ENS name display #14106
Fix ENS name display #14106
Conversation
Jenkins BuildsClick to see older builds (12)
|
97% of end-end tests have passed
Failed tests (3)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Passed tests (84)Click to expandClass TestGroupChatMultipleDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
|
3e3acd5
to
e957efa
Compare
100% of end-end tests have passed
Passed tests (3)Click to expandClass TestEnsStickersMultipleDevicesMerged:
|
@audriu bug is still reproducible for me in public and group chats. Use @pavlo ENS for reproduction. Don't forget to switch to mainnet first, because this is ENS registered on mainnet. Steps:
Actual result: public key instead of ENS in edited message. telegram-cloud-document-2-5323758473316410166.mp4 |
e957efa
to
52760c1
Compare
84% of end-end tests have passed
Failed tests (14)Click to expandClass TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Passed tests (73)Click to expandClass TestKeycardTxOneDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPublicChatMultipleDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestWalletManagementDeviceMerged:
|
36% of end-end tests have passed
Failed tests (9)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Passed tests (5)Click to expandClass TestSendTxDeviceMerged:
|
0% of end-end tests have passed
Failed tests (9)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
100% of end-end tests have passed
Passed tests (9)Click to expandClass TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
|
9d93f5d
to
a164424
Compare
a164424
to
410e15c
Compare
78% of end-end tests have passed
Failed tests (19)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestSendTxDeviceMerged:
Passed tests (68)Click to expandClass TestOneToOneChatMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestRestoreOneDeviceMerged:
|
26% of end-end tests have passed
Failed tests (14)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Passed tests (5)Click to expandClass TestSendTxDeviceMerged:
|
36% of end-end tests have passed
Failed tests (9)Click to expandClass TestRestoreOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Passed tests (5)Click to expandClass TestKeycardTxOneDeviceMerged:
|
100% of end-end tests have passed
Passed tests (9)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
|
Ok. Failed on this one. This PR works for me but not for QAs. I tried hard to reproduce but still works ok for me. Maybe someone with a fresh look can see wtf. Ping me if you need any help... |
Hi @audriu, should we close this PR? |
IDK. Maybe someone will want to see the work I have done when they start working. |
will be fixed in #14149 |
fixes #14051
this is a recreation of #14093 because of some of my mistakes
Summary
Fixes edited messages mentions
Platforms
Functional
Steps to test
status: Stuck. Maybe someone else wants to give it a try...