upgrade nixpkgs to 23-11 #19369
Merged
upgrade nixpkgs to 23-11 #19369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (80)
|
This was referenced Mar 22, 2024
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
d3c9d9c to
03afddf
Compare
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
from
03afddf to
51adf21
Compare
98% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
292b9d9 to
f824608
Compare
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
4 times, most recently
from
e63f5b3 to
6dc63b6
Compare
jakubgs
approved these changes
Mar 25, 2024
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
92f5e7c to
939e291
Compare
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
from
939e291 to
bb17681
Compare
apentori
approved these changes
Mar 26, 2024
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
5a6fe05 to
0195e7e
Compare
7 tasks
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
0e60c29 to
a7c33ba
Compare
|
Hey @siddarthkay! In this PR we experience issues with connection to store node. We are not reproducing this in develop, so assume this could be PR regression. See description below. In case this error is related to waku team please let us know. ISSUE 1 Communities are not fetched, "store node is not available" in logsSteps:
Actual result: telegram-cloud-document-2-5203941607451148720.mp4log from Status log log from geth log |
|
Thanks for testing @pavloburykh : I'll take a look. |
siddarthkay
commented
Mar 29, 2024
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
from
843780f to
2714eb6
Compare
|
Hi @siddarthkay ! Also found extra scenario caused by connection to store node. May be useful to reproducing problem. ISSUE 2: User created by using seed phrase has no restored data
Expected result: user will be recovered with data |
|
@siddarthkay I've checked new builds but unfortunately all issues are still exist on both platforms: iOS/Android
|
jo-mut
approved these changes
Mar 29, 2024
|
@pavloburykh @mariia-skrypnyk : |
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
2 times, most recently
from
aa41e85 to
cfa1bd3
Compare
85% of end-end tests have passedFailed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (41)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
100% of end-end tests have passedPassed tests (6)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
@siddarthkay I am not reproducing ISSUE 1 anymore. PR is ready for merge.
@siddarthkay by last commit you mean these changes #19369 (comment) ? If yes - then it is weird, because issue actually was reproducible for me and you after this commit when we checked on Friday. Or you committed some other changes which fixed the bug? |
|
Thanks for testing @pavloburykh ! |
Great, thank you @siddarthkay! |
fixes #18311 This PR upgrades `nixpkgs` to latest release version of 23-11 ref -> https://github.com/NixOS/nixpkgs/releases/tag/23.11 - `Gradle` from `8.0.1` -> `8.4` - `Git` from `2.40.1` -> `2.42.0` - `Curl` from `8.0.1` -> `8.4.0` - `OpenSSL` from `3.0.8` -> `3.0.13` - `NodeJS` from `18.16.0` -> `18.19.1` - `Python` from `3.10.11` -> `3.10.13` - `Clojure` from `1.11.1.1273` -> `1.11.1.1413` - and some more stuff - `xcbeautify` , this was added in 23-11 ->NixOS/nixpkgs#289446 - `idb-companion`, this was also added in 23-11 -> NixOS/nixpkgs#296440
siddarthkay
force-pushed
the
nixpkgs-upgrade-23-11
branch
from
cfa1bd3 to
4bd62eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18311
Summary
This PR upgrades
nixpkgsto latest release version of 23-11ref -> https://github.com/NixOS/nixpkgs/releases/tag/23.11
Following are the noteable upgrades :
Gradlefrom8.0.1->8.4Gitfrom2.40.1->2.42.0Curlfrom8.0.1->8.4.0OpenSSLfrom3.0.8->3.0.13NodeJSfrom18.16.0->18.19.1Pythonfrom3.10.11->3.10.13Clojurefrom1.11.1.1273->1.11.1.1413Following derivations were removed :
xcbeautify, this was added in 23-11 -> [23.11] backport xcbeautify: init at 1.4.0 NixOS/nixpkgs#289446idb-companion, this was also added in 23-11 -> [23.11] backport idb-companion: init at 1.1.8 NixOS/nixpkgs#296440Testing notes
Test Everything
Platforms
status: ready