[DEBUG] disable signals #9230
Closed
[DEBUG] disable signals #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (55)
|
cammellos
force-pushed
the
debug/disable-signals
branch
2 times, most recently
from
49294fd to
fa00f5b
Compare
cammellos
force-pushed
the
debug/disable-signals
branch
4 times, most recently
from
66b7a37 to
745f5b6
Compare
|
Tested the latest build on Galaxy Note 4 (http://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-191018-135824-745f5b-pr-universal.apk) No messages are received by that build, neither from offline inbox nor when two contacts (nightly build and PR build) exchange messages in public chat (but user using nightly develop build receives messages from 745f5b-pr-universal.apk user) |
|
ouch something went wrong, this build was supposed to receive messages, i
will take a look at it Monday
…On Fri, Oct 18, 2019, 16:30 Sergey Chumak ***@***.***> wrote:
Tested the latest build on Galaxy Note 4 (
http://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-191018-135824-745f5b-pr-universal.apk
)
No messages are received by that build, neither from offline inbox nor
when two contacts (nightly build and PR build) exchange messages in public
chat (but user using nightly develop build receives messages from
745f5b-pr-universal.apk user)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9230>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYJMBT5UTUGEZJZCO4CGDQPHB7DANCNFSM4JBNXQ5A>
.
|
cammellos
force-pushed
the
debug/disable-signals
branch
from
745f5b6 to
086f7a0
Compare
|
@Serhy this is ready to be tested again, it should receive messages, and should be better then current develop, although it stutters still a bit locally. |
cammellos
force-pushed
the
debug/disable-signals
branch
from
4ad1e5f to
54e7611
Compare
|
@Serhy should be working now, sorry, there was some issues with building production code that I did not address |
|
Latest build, http://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-191021-100023-54e761-pr-universal.apk tested, and indeed it's become better. Same scenario repeated 5 times and in average the time of app freezes are ~1.6-1.8 sec when receive 100 text messages from public chat (which ~40-45% faster than develop build!) |
cammellos
force-pushed
the
debug/disable-signals
branch
from
54e7611 to
792df32
Compare
|
@Serhy thanks for the good news! |
|
@cammellos very last build (https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-191021-133824-792df3-pr-universal.apk) looks definitely better for me! When 100 test messages fetching from offline app may freeze for ~1-1.2 sec which is almost three times better than develop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.