Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [#9037] Error states for new Tx overview: contract & network fees #9236

Closed
wants to merge 2 commits into from
Closed

[WIP] [#9037] Error states for new Tx overview: contract & network fees #9236

wants to merge 2 commits into from

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Oct 18, 2019 •
edited by StatusWrike
Loading

fixes #9037
WIP

@flexsurfer flexsurfer requested a review from a team as a code owner October 18, 2019 10:11
@flexsurfer flexsurfer self-assigned this Oct 18, 2019
@ghost
Copy link

ghost commented Oct 18, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@flexsurfer flexsurfer mentioned this pull request Oct 18, 2019
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 18, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 95bfb14 #1 2019-10-18 10:12:08 ~29 sec linux 📄log
❌ 95bfb14 #1 2019-10-18 10:12:08 ~31 sec android 📄log
❌ 95bfb14 #1 2019-10-18 10:12:08 ~27 sec windows 📄log
❌ 95bfb14 #1 2019-10-18 10:12:08 ~30 sec ios 📄log
❌ 95bfb14 #1 2019-10-18 10:12:13 ~33 sec macos 📄log
✔️ 95bfb14 #1 2019-10-18 10:23:05 ~11 min android-e2e 📦apk 📲

@flexsurfer flexsurfer changed the title [WIP] [#9037] Feature/transaction fail [WIP] [#9037] Error states for new Tx overview: contract & network fees Oct 18, 2019
@flexsurfer flexsurfer removed the request for review from a team October 18, 2019 10:56
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@flexsurfer flexsurfer closed this Jan 8, 2020
@jakubgs jakubgs deleted the feature/transaction-fail branch May 12, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error states for new Tx overview: contract & network fees
2 participants
@flexsurfer @status-im-auto