Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qr navigation bug in qr scanning #9476

Closed
wants to merge 1 commit into from

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Nov 18, 2019

fixes #9381

Summary

When the Scan QR code option is selected from the Chat home navigation and a QR code is scanned, later navigating back to the Chat tab returns to the QR scanner rather than the Chat Home and is clunky to the user. This fixes this issue and navigates the user to the chat home page upon next tap on the Chat menu item.

Platforms

  • Android
  • iOS
Functional
  • 1-1 chats
  • public chats
  • group chats
Non-functional

Steps to test

Open Status
(From the Chats Tab) tap on the + plus button
Tap on Scan QR code
Scan some code
Tap Chat to navigate to chat screen
Chat home view should display

status: ready

fix-qr-scan-navigation

@acolytec3 acolytec3 requested a review from a team as a code owner November 18, 2019 20:10
@auto-assign auto-assign bot removed the request for review from a team November 18, 2019 20:10
@ghost
Copy link

ghost commented Nov 18, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Nov 18, 2019

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8e4ce3e #1 2019-11-18 20:20:54 ~10 min ios 📦ipa 📲
✔️ 8e4ce3e #1 2019-11-18 20:22:46 ~12 min android-e2e 📦apk 📲
✔️ 8e4ce3e #1 2019-11-18 20:23:30 ~13 min android 📦apk 📲
✔️ 8e4ce3e #1 2019-11-18 20:25:57 ~15 min macos 📦dmg
✔️ 8e4ce3e #1 2019-11-18 20:29:35 ~19 min linux 📦App
✔️ 8e4ce3e #1 2019-11-18 20:31:00 ~20 min windows 📦exe
cdb99f0 #2 2019-11-19 19:02:55 ~3 min macos 📄log
cdb99f0 #2 2019-11-19 19:03:32 ~3 min linux 📄log
cdb99f0 #2 2019-11-19 19:03:32 ~3 min android-e2e 📄log
cdb99f0 #2 2019-11-19 19:03:42 ~3 min windows 📄log
cdb99f0 #2 2019-11-19 19:03:59 ~4 min android 📄log
cdb99f0 #2 2019-11-19 19:04:03 ~4 min ios 📄log
b22629a #3 2019-11-19 19:25:20 ~2 min android-e2e 📄log
b22629a #3 2019-11-19 19:25:21 ~2 min android 📄log
b22629a #3 2019-11-19 19:25:55 ~3 min macos 📄log
b22629a #3 2019-11-19 19:26:12 ~3 min ios 📄log
b22629a #3 2019-11-19 19:26:16 ~3 min linux 📄log
b22629a #3 2019-11-19 19:26:28 ~3 min windows 📄log
3290270 #4 2019-11-21 11:33:11 ~2 min linux 📄log
3290270 #4 2019-11-21 11:33:20 ~2 min windows 📄log
3290270 #4 2019-11-21 11:33:25 ~3 min android 📄log
3290270 #4 2019-11-21 11:33:25 ~3 min android-e2e 📄log
3290270 #4 2019-11-21 11:33:28 ~3 min macos 📄log
3290270 #4 2019-11-21 11:34:44 ~4 min ios 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 54072f7 #5 2019-11-21 13:03:14 ~9 min ios 📦ipa 📲
✔️ 47fe6e1 #6 2019-11-21 13:14:58 ~8 min ios 📦ipa 📲
✔️ 47fe6e1 #6 2019-11-21 13:16:47 ~10 min android-e2e 📦apk 📲
✔️ 47fe6e1 #6 2019-11-21 13:18:34 ~12 min linux 📦App
✔️ 47fe6e1 #6 2019-11-21 13:19:54 ~13 min android 📦apk 📲
✔️ 47fe6e1 #6 2019-11-21 13:20:15 ~13 min macos 📦dmg
✔️ 47fe6e1 #6 2019-11-21 13:20:49 ~14 min windows 📦exe

@acolytec3 acolytec3 force-pushed the fix-qr-navigation-bug branch 2 times, most recently from b22629a to 3290270 Compare November 21, 2019 11:29
@acolytec3
Copy link
Contributor Author

Just rebased on develop but looks like the builds are still failing. Can someone tell me what the logs are saying?

@acolytec3 acolytec3 force-pushed the fix-qr-navigation-bug branch from 54072f7 to 47fe6e1 Compare November 21, 2019 13:05
@flexsurfer
Copy link
Member

sorry @acolytec3 i've reworked qr scanner here #9499 , now it's modal ,so this issues will be addressed in this PR

@flexsurfer flexsurfer closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Chat's QRCode scanner dont exits after scan
4 participants