Send transaction GUI #9499
Merged
Send transaction GUI #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (39)
|
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
36ec0bd to
1f1ceda
Compare
flexsurfer
requested review from
a team
and removed request for
yenda and
a team
This was referenced Nov 21, 2019
yenda
reviewed
Nov 21, 2019
| @@ -81,6 +81,7 @@ | |||
| (navigation/navigate-to-cofx (assoc-in cofx [:db :contacts/identity] public-key) :profile nil)))) | |||
|
|
|||
| (fx/defn handle-eip681 [cofx url] | |||
| ;;TODO !!!!!!!! | |||
yenda
reviewed
Nov 21, 2019
| {:permissions [:camera] | ||
| :on-allowed | ||
| #(do | ||
| (re-frame/dispatch [:bottom-sheet/hide-sheet]) |
There was a problem hiding this comment.
is code that got moved? could you create an event to avoid the triple dispatch?
There was a problem hiding this comment.
will fix to one event
yenda
reviewed
Nov 21, 2019
| (for [item [{:title (i18n/label :t/accounts) | ||
| :icon :main-icons/profile | ||
| :theme :action | ||
| :on-press #(do |
There was a problem hiding this comment.
is code that got moved? could you create an event to avoid the triple dispatch?
There was a problem hiding this comment.
will fix to one event
yenda
reviewed
Nov 21, 2019
| :icon :main-icons/address | ||
| :theme :action | ||
| :on-press #(do | ||
| (re-frame/dispatch [:bottom-sheet/hide-sheet]) |
There was a problem hiding this comment.
is code that got moved? could you create an event to avoid the triple dispatch?
There was a problem hiding this comment.
will fix to one event
yenda
reviewed
Nov 21, 2019
| [list-item/list-item | ||
| {:icon [chat-icon/custom-icon-view-list (:name account) (:color account)] | ||
| :title (:name account) | ||
| :on-press #(do |
There was a problem hiding this comment.
is code that got moved? could you create an event to avoid the double dispatch?
There was a problem hiding this comment.
will fix to one event
yenda
reviewed
Nov 21, 2019
| :key-fn (comp str :symbol) | ||
| :render-fn (wallet.accounts/render-asset | ||
| (:code currency) | ||
| #(do |
There was a problem hiding this comment.
is code that got moved? could you create an event to avoid the double dispatch?
There was a problem hiding this comment.
will fix to one event
yenda
reviewed
Nov 21, 2019
| ["re-frame: overwriting" | ||
| "Warning: componentWillMount is deprecated and will be removed in the next major version. Use componentDidMount instead. As a temporary workaround, you can rename to UNSAFE_componentWillMount." | ||
| "Warning: componentWillUpdate is deprecated and will be removed in the next major version. Use componentDidUpdate instead. As a temporary workaround, you can rename to UNSAFE_componentWillUpdate."]) | ||
| #js ["re-frame: overwriting" |
There was a problem hiding this comment.
nothing, just fixed formatting
yenda
reviewed
Nov 21, 2019
| @@ -0,0 +1,44 @@ | |||
| (ns status-im.ui.screens.chat.extensions.views | |||
There was a problem hiding this comment.
is it the gui commands selection panel?
yenda
reviewed
Nov 21, 2019
| (re-frame/dispatch [:qr-scanner.callback/scan-qr-code-cancel identifier]) | ||
| (re-frame/dispatch [:navigate-back])))] | ||
| [toolbar/content-title title]]]) | ||
| (defn- viewfinder [size] |
There was a problem hiding this comment.
what is this component doing?
|
@yenda PR isn't ready for review yet |
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
1f1ceda to
35521c8
Compare
errorists
reviewed
Nov 22, 2019
errorists
reviewed
Nov 22, 2019
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
27e4dac to
56f1992
Compare
|
@yenda ready for review |
84% of end-end tests have passedFailed tests (15)Click to expand
Passed tests (78)Click to expand |
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
56f1992 to
9ab9842
Compare
|
@flexsurfer, I can't send transaction from any network besides Mainnet.
|
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
9ab9842 to
ecb0f32
Compare
|
thanks @Serhy , fixed ,also added network name |
|
Tested on Xiaomi Mi Note 9 Pro:
Looks good to me. |
yenda
approved these changes
Nov 27, 2019
Signed-off-by: Andrey Shovkoplyas <[email protected]>
flexsurfer
force-pushed
the
feature/send-transaction
branch
from
ecb0f32 to
507cc5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO: https://www.youtube.com/watch?v=7nyXYO18JNg
also
fixes #9381
fixes #9210
FOR QA: sending tx from the chat is not in the scope of this PR, please text only sending from the wallet