Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'chats' to 'chat' #9512

Closed
wants to merge 1 commit into from
Closed

Change 'chats' to 'chat' #9512

wants to merge 1 commit into from

Conversation

rachelhamlin
Copy link
Contributor

  • Uncapitalizing "Public Chats" on empty chat screen
  • Changing "Chats" to "Chat" in bottom nav

@rachelhamlin
Change 'chats' to 'chat'
324bfd3 
- Uncapitalizing "Public Chats" on empty chat screen
- Changing "Chats" to "Chat" in bottom nav
@rachelhamlin rachelhamlin requested a review from a team as a code owner November 22, 2019 14:03
@auto-assign auto-assign bot removed the request for review from a team November 22, 2019 14:03
@ghost
Copy link

ghost commented Nov 22, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Nov 22, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 324bfd3 #1 2019-11-22 14:12:06 ~8 min ios 📦ipa 📲
✔️ 324bfd3 #1 2019-11-22 14:17:07 ~13 min macos 📦dmg
✔️ 324bfd3 #1 2019-11-22 14:19:10 ~15 min linux 📦App
✔️ 324bfd3 #1 2019-11-22 14:19:39 ~16 min windows 📦exe
✔️ 324bfd3 #1 2019-11-22 14:21:35 ~18 min android-e2e 📦apk 📲
✔️ 324bfd3 #1 2019-11-22 14:21:40 ~18 min android 📦apk 📲

@flexsurfer
Copy link
Member

will be addressed here #9499

@flexsurfer flexsurfer closed this Nov 22, 2019
@jakubgs jakubgs deleted the rachelhamlin-patch-3 branch May 12, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelhamlin @status-im-auto @flexsurfer