Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated attribute_was #370

Closed
wants to merge 2 commits into from

Conversation

Bramjetten
Copy link

The behavior of attribute_was inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use attribute_before_last_save instead.

The behavior of `attribute_was` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `attribute_before_last_save` instead.
@coveralls
Copy link

coveralls commented Dec 26, 2017

Coverage Status

Coverage decreased (-0.3%) to 97.23% when pulling fb7ca8c on Bramjetten:master into 8c9ba36 on stefankroes:master.

@kbrock
Copy link
Collaborator

kbrock commented Apr 19, 2018

Thank you for explaining the current issue.

I've changed over the code to use was (bad) to get everything passing in 5.2
I'm currently going through and trying to consolidate the accesses to the was variables.

Please let me know if you have any suggestions for what we now do on master.

@kbrock
Copy link
Collaborator

kbrock commented May 2, 2018

Thanks for the PR.

Think this needed a few more changes
Let me know if #387 meets your needs

Thanks

@kbrock kbrock closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants