Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use before_last_save for rails >= 5.1 #387

Merged
merged 1 commit into from
May 4, 2018

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented May 2, 2018

The {attribute}_was has changed. there are now 2 different methods

changed the code according to whether it was called in the
after save (needed to use _before_last_save) OR
before save/destroy callback (still use _was)

This will remove rails 5.1 deprecation warnings

This is in response to #379 from @jjuliano
Thanks for the help @khustochka
Thanks for the PR @Bramjetten

if you all could give a quick peek, that would be appreciated

Fixes #372

The {attribute}_was has changed. there are now 2 different methods

changed the code according to whether it was called in the 
after save (needed to use _before_last_save) OR
before save/destroy callback (still use _was)

This will remove rails 5.1 deprecation warnings
@coveralls
Copy link

coveralls commented May 2, 2018

Coverage Status

Coverage decreased (-0.2%) to 98.108% when pulling ef25574 on kbrock:51_warnings_pt2 into 9f226a4 on stefankroes:master.

@kbrock kbrock merged commit c07775b into stefankroes:master May 4, 2018
@kbrock kbrock deleted the 51_warnings_pt2 branch May 4, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants