Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: drop support for hex contract IDs #658

Merged
merged 1 commit into from
Jul 28, 2023
Merged

feat!: drop support for hex contract IDs #658

merged 1 commit into from
Jul 28, 2023

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 27, 2023

Fixes #650

chadoh
chadoh commented Jul 27, 2023
View reviewed changes
test/unit/contract_test.js
let contract = new StellarBase.Contract(contractId);
expect(contract.contractId('hex')).to.equal(contractId);
});
const NULL_ADDRESS = 'CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this by using the current version of stellar-base and:

let contractId = '0'.repeat(63) + '1';
let contract = new StellarBase.Contract(contractId);
contract.address('strkey')

@chadoh chadoh force-pushed the feat/rm-hex-contract-ids branch 2 times, most recently from dfcdc8b to 8499ac3 Compare July 28, 2023 18:09
@chadoh chadoh marked this pull request as ready for review July 28, 2023 18:09
@Shaptic Shaptic self-requested a review July 28, 2023 18:18
Shaptic
Shaptic reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update types/index.d.ts signatures 🙏 otherwise this is almost ready

src/contract.js Outdated Show resolved Hide resolved
test/unit/contract_test.js Show resolved Hide resolved
@chadoh chadoh force-pushed the feat/rm-hex-contract-ids branch from 8499ac3 to 0ec7336 Compare July 28, 2023 18:45
@chadoh chadoh force-pushed the feat/rm-hex-contract-ids branch from 0ec7336 to 2f4bd45 Compare July 28, 2023 18:50
@chadoh
Copy link
Contributor Author

chadoh commented Jul 28, 2023

Needing to manually update *.d.ts files 😩

All feedback addressed.

Shaptic
Shaptic approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you! 👏 mind adding a breaking change entry to #661 so we have it documented?

@chadoh
Copy link
Contributor Author

chadoh commented Jul 28, 2023

I don't have the ability to edit the description there, if that's what you mean

@Shaptic
Copy link
Contributor

Shaptic commented Jul 28, 2023

That is what I meant - no worries! I'll do it

@Shaptic Shaptic merged commit 4113bb9 into stellar:soroban Jul 28, 2023
@chadoh chadoh deleted the feat/rm-hex-contract-ids branch July 28, 2023 19:09
This was referenced Jul 28, 2023
Merged
Closed
Shaptic added a commit that referenced this pull request Sep 12, 2023
@Shaptic @overcat
@dependabot @orbitlens @piyalbasu @sreuland @silence48 @chadoh @jeesunikim
Merge: Adds Protocol 20/Soroban support to the XDR and API. (#538)
4182cca 
* Correctly set `minAccountSequence` in `TransactionBuilder` for large values (#539)
* Add support of CAP40 ed25519SignedPayload signer for SetOptionOp (#542)
* Add TypeScript interfaces for Ed25519SignedPayload signers
* Coalesce all xLM, Xlm, etc. => 'XLM' native asset code (#546)
* make sure sodium is not an empty object in service workers (#567)
* Add futurenet passphrase for soroban. (#550)
* Include standalone network passphrase (#555)
* Soroban auth next updates (#570)
* Add strkey parsing for contracts, and Address helper for building ScAddresses (#572)
* Update xdr to include HashIdPreimageContractAuth.nonce (#577)
* Add Address.toBuffer method (#578)
* Soroban value overhaul (#582)
* Update generated XDR to latest version. (#587)
* Update XDR and contract invocations to conform to the latest version (Preview 9). (#601)
* added soroban transaction data as tx builder param (#604)
* Add Contract support for strkey-style contract IDs (#612)
* Add Contract.address() method (#614)
* Add wrappers to easily deal with the myriad of `ScVal` integer types. (#620)
* Upgrade `js-xdr` to v3.0.0 to support `bigint` encoding.
* Add wrappers to easily convert between `ScVal` and native types. (#630)
* Update XDR to support Preview 10 (#633)
* Fix TypeScript definition for `invokeHostFunction` options (#635)
* Add fully-qualified `Operation` type to XDR type definitions. (#591)
* Adds Operation.isValidAmount jsdoc (#609)
* Removes the dependency on `crc` by calculating checksum in strkey (#621)
* Improve type flexibility when building `ScVal`s from native types (#638)
* Fix Preview 10 contract invoke & release `v10.0.0-soroban.3` (#642)
* Add GitHub Action that compares before-and-after bundle sizes. (#644)
* Make opinionated judgements about string/symbol decoding (#645)
* Make Node 16 the minimum version. (#651)
* Add standalone/futurenet passphrases to jsdoc (#654)
* Clean up unnecessary dependency entries (#652)
* Add `SorobanDataBuilder` builder pattern to prepare transactions easier (#660)
* Adds a way to create a `TransactionBuilder` from an existing transaction. (#656)
* Add basic contract event parsing into a human-readable structure (#659)
* Drop support for deprecated hex contract IDs (#658)
* Add helpers method to build authorization entries. (#663)
* Fix TypeScript definition for new static `TransactionBuilder` constructor (#665)
* Add ability to clear out operations from the transaction builder (#670)
* Add an existing method to XdrLargeInt, jsdoc/types fixup (#668)
* Expand contract footprint with contract code ledger key. (#662)
* Decode base64-encoded strings in new SorobanDataBuilder (#673)
* Add ability to modify and retrieve the resource footprint (#680)
* Fixes error messages for required amount parameters (#679)
* Add `Asset.contractId()` helper to predict contract IDs (#684)
* Upgrade dependencies to their latest minor/patch version (#685)
* Improves `SorobanDataBuilder` construction and adds a getter (#686)
* Add JSON-ification of Soroban invocation trees. (#669)
* Add utilities for formatting token amounts (`formatTokenAmount` & `parseTokenAmount`) (#667)
* Merges the final Protocol 20 XDR (i.e. for testnet) into `soroban` (#688)
* Add support to convert strings to large integer and address `ScVal`s (#690)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Paul Bellamy <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: Jun Luo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: OrbitLens <[email protected]>
Co-authored-by: Piyal Basu <[email protected]>
Co-authored-by: George Kudrayvtsev <[email protected]>
Co-authored-by: shawn <[email protected]>
Co-authored-by: Silence <[email protected]>
Co-authored-by: Chad Ostrowski <[email protected]>
Co-authored-by: jeesun 지선 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadoh @Shaptic