Add utilities for formatting token amounts (`formatTokenAmount` and `parseTokenAmount`) #667

jeesunikim · 2023-08-08T16:46:10Z

Summary:

adding soroban token display formatter and parser from
moving the commonly used functions parseTokenAmount and formatTokenAmount from soroban-react-payment

src/soroban.js

test/unit/soroban_test.js

src/soroban.js

Shaptic · 2023-08-08T20:07:07Z

I'm confused about why CI isn't running 🤨

aristidesstaffieri · 2023-08-08T21:51:11Z

btw the original inspiration for these is here and they do some extra stuff that we don't like work with negative values so maybe worth discussing? Ours have worked for all of our use cases so far but they may get used differently as part of the sdk.

Shaptic · 2023-08-08T22:08:04Z

@aristidesstaffieri thanks for the ref! we should steal their (non-negative) test cases, then. I think the usage aligns (besides multiplier, which I don't understand).

Btw, a lot of the code comments in this review I'd make there, too, but I bet theirs was written before e.g. .padEnd or ?? support was common in JS.

aristidesstaffieri · 2023-08-09T20:09:25Z

I'm confused about why CI isn't running 🤨

Github is having issues, probably related https://www.githubstatus.com/incidents/nwb8m3ppfxw6

config/.eslintrc.js

src/soroban.js

test/unit/soroban_test.js

src/soroban.js

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: George <[email protected]>

github-actions · 2023-08-24T00:02:14Z

Size Change: +50.6 kB (+2%)

Total Size: 3.13 MB

Filename	Size	Change
`dist/stellar-base.js`	2.3 MB	+36.8 kB (+2%)
`dist/stellar-base.min.js`	834 kB	+13.7 kB (+2%)

_{compressed-size-action}

Shaptic

One bug, I think, and I'd love to see a few more test cases so we can validate the behavior better! But I think this is almost ready besides that. (Also you need to run yarn fmt heh.)

test/unit/soroban_test.js

src/soroban.js

Co-authored-by: George <[email protected]>

…yarn fmt

src/soroban.js

Shaptic

Woohoo, we made it!! Thanks for this 👏

* Correctly set `minAccountSequence` in `TransactionBuilder` for large values (#539) * Add support of CAP40 ed25519SignedPayload signer for SetOptionOp (#542) * Add TypeScript interfaces for Ed25519SignedPayload signers * Coalesce all xLM, Xlm, etc. => 'XLM' native asset code (#546) * make sure sodium is not an empty object in service workers (#567) * Add futurenet passphrase for soroban. (#550) * Include standalone network passphrase (#555) * Soroban auth next updates (#570) * Add strkey parsing for contracts, and Address helper for building ScAddresses (#572) * Update xdr to include HashIdPreimageContractAuth.nonce (#577) * Add Address.toBuffer method (#578) * Soroban value overhaul (#582) * Update generated XDR to latest version. (#587) * Update XDR and contract invocations to conform to the latest version (Preview 9). (#601) * added soroban transaction data as tx builder param (#604) * Add Contract support for strkey-style contract IDs (#612) * Add Contract.address() method (#614) * Add wrappers to easily deal with the myriad of `ScVal` integer types. (#620) * Upgrade `js-xdr` to v3.0.0 to support `bigint` encoding. * Add wrappers to easily convert between `ScVal` and native types. (#630) * Update XDR to support Preview 10 (#633) * Fix TypeScript definition for `invokeHostFunction` options (#635) * Add fully-qualified `Operation` type to XDR type definitions. (#591) * Adds Operation.isValidAmount jsdoc (#609) * Removes the dependency on `crc` by calculating checksum in strkey (#621) * Improve type flexibility when building `ScVal`s from native types (#638) * Fix Preview 10 contract invoke & release `v10.0.0-soroban.3` (#642) * Add GitHub Action that compares before-and-after bundle sizes. (#644) * Make opinionated judgements about string/symbol decoding (#645) * Make Node 16 the minimum version. (#651) * Add standalone/futurenet passphrases to jsdoc (#654) * Clean up unnecessary dependency entries (#652) * Add `SorobanDataBuilder` builder pattern to prepare transactions easier (#660) * Adds a way to create a `TransactionBuilder` from an existing transaction. (#656) * Add basic contract event parsing into a human-readable structure (#659) * Drop support for deprecated hex contract IDs (#658) * Add helpers method to build authorization entries. (#663) * Fix TypeScript definition for new static `TransactionBuilder` constructor (#665) * Add ability to clear out operations from the transaction builder (#670) * Add an existing method to XdrLargeInt, jsdoc/types fixup (#668) * Expand contract footprint with contract code ledger key. (#662) * Decode base64-encoded strings in new SorobanDataBuilder (#673) * Add ability to modify and retrieve the resource footprint (#680) * Fixes error messages for required amount parameters (#679) * Add `Asset.contractId()` helper to predict contract IDs (#684) * Upgrade dependencies to their latest minor/patch version (#685) * Improves `SorobanDataBuilder` construction and adds a getter (#686) * Add JSON-ification of Soroban invocation trees. (#669) * Add utilities for formatting token amounts (`formatTokenAmount` & `parseTokenAmount`) (#667) * Merges the final Protocol 20 XDR (i.e. for testnet) into `soroban` (#688) * Add support to convert strings to large integer and address `ScVal`s (#690) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Bellamy <[email protected]> Co-authored-by: George <[email protected]> Co-authored-by: Jun Luo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: OrbitLens <[email protected]> Co-authored-by: Piyal Basu <[email protected]> Co-authored-by: George Kudrayvtsev <[email protected]> Co-authored-by: shawn <[email protected]> Co-authored-by: Silence <[email protected]> Co-authored-by: Chad Ostrowski <[email protected]> Co-authored-by: jeesun 지선 <[email protected]>

Shaptic reviewed Aug 8, 2023

View reviewed changes

Shaptic changed the base branch from master to soroban August 8, 2023 19:02

Shaptic changed the title ~~add 'formatTokenAmount' and 'parseTokenAmount'~~ Add utilities for formatting token amounts (formatTokenAmount and parseTokenAmount) Aug 8, 2023

Shaptic reviewed Aug 8, 2023

View reviewed changes

test/unit/soroban_test.js Outdated Show resolved Hide resolved

test/unit/soroban_test.js Outdated Show resolved Hide resolved

src/soroban.js Show resolved Hide resolved

Shaptic force-pushed the soroban branch from 3b95892 to 7c85cc4 Compare August 10, 2023 17:40

Shaptic mentioned this pull request Aug 11, 2023

Feature/soroban sdk v0.10.0 + fixes stellar/soroban-react-atomic-swap#11

Merged

jeesunikim commented Aug 15, 2023

View reviewed changes

config/.eslintrc.js Outdated Show resolved Hide resolved

jeesunikim commented Aug 15, 2023

View reviewed changes

src/soroban.js Outdated Show resolved Hide resolved

jeesunikim commented Aug 15, 2023

View reviewed changes

src/soroban.js Outdated Show resolved Hide resolved

Shaptic reviewed Aug 15, 2023

View reviewed changes

Shaptic reviewed Aug 21, 2023

View reviewed changes

src/soroban.js Outdated Show resolved Hide resolved

dependabot bot and others added 10 commits August 23, 2023 16:59

add 'formatTokenAmount' and 'parseTokenAmount'

2b7034d

yarn fmt

2ad6569

Update src/soroban.js

87d9818

Co-authored-by: George <[email protected]>

Update test/unit/soroban_test.js

3c0312e

Co-authored-by: George <[email protected]>

remove BigNumber and apply feedback

039622e

Update src/soroban.js

674a1a6

Co-authored-by: George <[email protected]>

Update src/soroban.js

811a3ba

Co-authored-by: George <[email protected]>

update following George's feedback

e7ed730

update soroban helper and its tesT

0288456

jeesunikim force-pushed the jee-wal-988 branch from a414282 to 0288456 Compare August 23, 2023 23:59

Shaptic reviewed Aug 25, 2023

View reviewed changes

test/unit/soroban_test.js Outdated Show resolved Hide resolved

src/soroban.js Outdated Show resolved Hide resolved

src/soroban.js Outdated Show resolved Hide resolved

jeesunikim and others added 2 commits August 25, 2023 11:29

Update src/soroban.js

a3e6a59

Co-authored-by: George <[email protected]>

write a function case where decimal is more than amount length & run …

beaa8e7

…yarn fmt

jeesunikim commented Sep 6, 2023

View reviewed changes

src/soroban.js Outdated Show resolved Hide resolved

Jeesun Kim added 2 commits September 5, 2023 17:35

removing trailing zeros only if it's decimal

3444ced

use only 'decimals'

33aeb84

Shaptic approved these changes Sep 6, 2023

View reviewed changes

jeesunikim merged commit 7288730 into soroban Sep 6, 2023

jeesunikim deleted the jee-wal-988 branch September 6, 2023 17:38

Shaptic mentioned this pull request Mar 25, 2024

[Soroban] Add token parsing/formatting functions stellar/typescript-wallet-sdk#106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add utilities for formatting token amounts (`formatTokenAmount` and `parseTokenAmount`) #667

Add utilities for formatting token amounts (`formatTokenAmount` and `parseTokenAmount`) #667

jeesunikim commented Aug 8, 2023

Shaptic commented Aug 8, 2023

aristidesstaffieri commented Aug 8, 2023

Shaptic commented Aug 8, 2023

aristidesstaffieri commented Aug 9, 2023

github-actions bot commented Aug 24, 2023 •

edited

Loading

Shaptic left a comment •

edited

Loading

Shaptic left a comment

Add utilities for formatting token amounts (formatTokenAmount and parseTokenAmount) #667

Add utilities for formatting token amounts (formatTokenAmount and parseTokenAmount) #667

Conversation

jeesunikim commented Aug 8, 2023

Shaptic commented Aug 8, 2023

aristidesstaffieri commented Aug 8, 2023

Shaptic commented Aug 8, 2023

aristidesstaffieri commented Aug 9, 2023

github-actions bot commented Aug 24, 2023 • edited Loading

Shaptic left a comment • edited Loading

Choose a reason for hiding this comment

Shaptic left a comment

Choose a reason for hiding this comment

Add utilities for formatting token amounts (`formatTokenAmount` and `parseTokenAmount`) #667

Add utilities for formatting token amounts (`formatTokenAmount` and `parseTokenAmount`) #667

github-actions bot commented Aug 24, 2023 •

edited

Loading

Shaptic left a comment •

edited

Loading