Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to determine if a signer was updated or added from operation result and meta #711

Closed
nullstyle opened this issue Aug 24, 2015 · 1 comment · Fixed by #944
Closed
Assignees

Comments

@nullstyle
Copy link
Contributor

At present it is very tough in the context of the horizon importer to determine whether or not a signer was added or updated within a SetOptionsOp operation.

To determine whether the modified signer was updated or created for the first time, the only feasible methods are:

  1. find the previous state of the account by loading it from the history system, somehow.
  2. search back through horizon's imported history api for the previous state of the signer

Both of these seem to be very costly and/or cludgy. Ideally, we could just add a flag on the SetOptionsResult that tells me whether a signer was added/updated/removed as a result of the operation being applied.

@nullstyle
Copy link
Contributor Author

#712 contains one possible way to improve this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants