Emit ledger entry in meta before modifying it #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it precedes updates or deletes in the meta data (if applicable: only when it's a new change in the current ledger)
|
@nullstyle |
|
@MonsieurNicolas thanks for the heads up, I'll work on updating horizon today |
latobarita
added a commit
that referenced
this pull request
Dec 7, 2015
Emit ledger entry in meta before modifying it Reviewed-by: jedmccaleb
This was referenced Dec 7, 2015
nullstyle
added a commit
to stellar-deprecated/horizon-importer
that referenced
this pull request
Dec 7, 2015
Add support for stellar/stellar-core#944
This was referenced Jan 9, 2020
bartekn
added a commit
to stellar/go
that referenced
this pull request
Jan 10, 2020
This commit removes support for ingesting `TransactionMeta.V=0` in `io.LedgerTransaction.GetChanges`. The code generating V0 meta was changed in stellar-core but without upgrading the V param. Some V0 meta has only one `LEDGER_ENTRY_STATE` emitted only when a ledger entry is first modified in a ledger but others add it before every `LEDGER_ENTRY_UPDATE` and `LEDGER_ENTRY_REMOVED`. It looks like the code to parse meta to support both cases should be possible but since transaction meta in protocol version <10 can be incomplete (see [1]) users still need to switch to V2 to be able to parse it. [1] #1902 [2] stellar/stellar-core#944 [3] stellar/stellar-core#1441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds an optional LEDGER_ENTRY_STATE before LEDGER_ENTRY_UPDATED and LEDGER_ENTRY_REMOVED.
The new meta is emitted when a ledger entry is first modified in a ledger:
given a transaction set that produces a stream of meta, the very first UPDATE/REMOVE for any given ledger entry will be preceded by a STATE entry.
The idea is that a consumer of this information will load the meta for a specific ledger close, and can with the new meta know what the state before applying transactions looks like.
This resolves #719
This should help with various scenarios tracked in issues like
not possible to determine if a signer was added or removed Resolves #711
not possible to determine if a signer is re-enabled or updated Resolves #712