Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tough to determine whether the master signer for account is re-enabled or just updated based upon operation result and meta #712

Closed
nullstyle opened this issue Aug 24, 2015 · 0 comments · Fixed by #944
Assignees

Comments

@nullstyle
Copy link
Contributor

Similar to #711, I am having trouble differentiated between when the master signer for an account is re-enabled versus when it is simply having it's weight updated.

Ideally, we would add some info to the SetOptionsResult object to specify how the master signer was affects in this operation, if at all.

As a proposal, I would say we should add a new enum to the XDR defs:

enum SignerChange {
  SIGNER_CHANGE_ADDED = 0,
  SIGNER_CHANGE_UPDATED = 1,
  SIGNER_CHANGE_REMOVED = 2
};

Then SetOptionsResult would become something like:

union SetOptionsResult switch (SetOptionsResultCode code)
{
  case SET_OPTIONS_SUCCESS:
     struct {
       SignerChange *masterSignerChange;
       SignerChange *signerChange;
    } success;
  default:
      void;
  };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants