Skip to content

Commit

Permalink
move mop::observable to mop::internals::observable (#95)
Browse files Browse the repository at this point in the history
  • Loading branch information
doy committed Oct 2, 2013
1 parent 2471fe1 commit d385f99
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions lib/mop.pm
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use mop::class;
use mop::method;
use mop::attribute;

use mop::observable;
use mop::internals::observable;

use mop::internals::syntax;
use mop::internals::mro;
Expand Down Expand Up @@ -216,7 +216,7 @@ sub bootstrap {
mop::class
mop::attribute
mop::method
mop::observable
mop::internals::observable
];

my $Object = find_meta('mop::object');
Expand All @@ -226,7 +226,7 @@ sub bootstrap {

my $Method = find_meta('mop::method');
my $Attribute = find_meta('mop::attribute');
my $Observable = find_meta('mop::observable');
my $Observable = find_meta('mop::internals::observable');

# At this point the metaclass
# layer class to role relationship
Expand All @@ -250,7 +250,7 @@ sub bootstrap {
}

# and now this is no longer needed
remove_meta('mop::observable');
remove_meta('mop::internals::observable');

foreach my $meta ( $Object, $Method, $Attribute, $Class, $Role ) {
$meta->FINALIZE;
Expand Down
2 changes: 1 addition & 1 deletion lib/mop/attribute.pm
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use Scalar::Util qw[ weaken ];
our $VERSION = '0.01';
our $AUTHORITY = 'cpan:STEVAN';

use parent 'mop::object', 'mop::observable';
use parent 'mop::object', 'mop::internals::observable';

mop::internals::util::init_attribute_storage(my %name);
mop::internals::util::init_attribute_storage(my %original_id);
Expand Down
2 changes: 1 addition & 1 deletion lib/mop/observable.pm → lib/mop/internals/observable.pm
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package mop::observable;
package mop::internals::observable;

use v5.16;
use warnings;
Expand Down
2 changes: 1 addition & 1 deletion lib/mop/method.pm
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use Scalar::Util qw[ weaken ];
our $VERSION = '0.01';
our $AUTHORITY = 'cpan:STEVAN';

use parent 'mop::object', 'mop::observable';
use parent 'mop::object', 'mop::internals::observable';

mop::internals::util::init_attribute_storage(my %name);
mop::internals::util::init_attribute_storage(my %body);
Expand Down
2 changes: 1 addition & 1 deletion lib/mop/role.pm
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use Module::Runtime qw[ is_module_name module_notional_filename ];
our $VERSION = '0.01';
our $AUTHORITY = 'cpan:STEVAN';

use parent 'mop::object', 'mop::observable';
use parent 'mop::object', 'mop::internals::observable';

mop::internals::util::init_attribute_storage(my %name);
mop::internals::util::init_attribute_storage(my %version);
Expand Down
4 changes: 2 additions & 2 deletions t/120-bugs/010-bread-board-bug.t
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ use mop;
This issue came up after doy made a number of
tweaks to the role composition and it uncovered
an issue with the mop::observable role, which
basically boiled down to the fact it wasn't
an issue with the mop::internals::observable role,
which basically boiled down to the fact it wasn't
properly storing SCALAR refs in the $callbacks
fieldhash. This is just a simple test to
check for this specific issue.
Expand Down

0 comments on commit d385f99

Please sign in to comment.