Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should mop::observable be an actual part of the mop? #95

Closed
doy opened this issue Oct 2, 2013 · 4 comments
Closed

should mop::observable be an actual part of the mop? #95

doy opened this issue Oct 2, 2013 · 4 comments
Labels

Comments

@doy
Copy link
Collaborator

doy commented Oct 2, 2013

It's not quite clear if the intention is to allow user classes to be able to do with mop::observable or not. It's also not mentioned at all in the docs, and the bootstrap doesn't actually end up with it being visible at all. Should it be a real thing, or just an implementation detail?

@stevan
Copy link
Owner

stevan commented Oct 2, 2013

It is for internal use only.

@doy
Copy link
Collaborator Author

doy commented Oct 2, 2013

Actually, looking at the bootstrap, it does end up being true that mop::observable ends up in the list produced by mop::meta('mop::class')->roles and such. Is this what we want? If it is, should we document mop::observable as a separate thing? If not, should we fix that?

@stevan
Copy link
Owner

stevan commented Oct 2, 2013

I think maybe we should move mop::observable into mop::internal:: and make it an implementation detail.

@doy
Copy link
Collaborator Author

doy commented Oct 2, 2013

Done.

@doy doy closed this as completed Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants