Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning message for already registered custom element #126

Merged

Conversation

marcoroth
Copy link
Member

Type of PR

"Bug fix"

Description

In #124 I introduced a warning message that would warn a developer if the custom element stream-from was already registered. It turns out that we can't check it that easily with our setup - especially if you are using CableReady via a different package in your app.

Long story short: This PR removes that check since it always showed the warning message, even if everything was fine.

Why should this be added

To avoid confusion about the already registered custom element.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

@leastbad leastbad merged commit 73ac528 into stimulusreflex:master May 15, 2021
@marcoroth marcoroth deleted the remove-custom-element-warning branch May 15, 2021 21:09
@marcoroth marcoroth restored the remove-custom-element-warning branch December 18, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants