-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OperationStore
to add operations on-the-fly
#124
Conversation
This also removes the `playSound` operation. The operation has been extracted to: https://github.com/cableready/audio_operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a masterclass-level refactoring job. Bravo.
Would it make sense to implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Great job.
I'm ok to punt on this unless y'all feel we should do it now vs later. |
and when it's not our `stream-from` element
Type of PR
Feature
Description
This PR introduces a
OperationStore
to add operations on-the-fly.This also removes the
playSound
operation. The operation has been extracted to: https://github.com/cableready/audio_operationsWith that a developer can add custom operations from packages to their app.
Deprecate
CableReady.DOMOperations
As CableReady is more than just "DOM operations" we should also change the name. This is still supported but shows a deprecation warning:
Instead you can now use this:
As a side effect it now also allows more ways of defining custom operations:
Why should this be added
Developers can build npm packages with pre-build CableReady operations and just add them with a simple function call to CableReady.
Checklist