Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Removal
Description
This pull requests removes the CableReady plugin system.
Reverts #227
Why should this be removed
The reason why the plugin system was introduced was the abstract away the fact that the
morph
operation was usingmorphdom
under the hood and because it was easily confused with StimulusReflexes'morph
method which is available in any Reflex class.The plugin system was not solving the underlying issue, it was just delegating it to the
Plugins
"class". We already introduced theOperationStore
concept for this exact use-case in #124. Also, if we really want to get rid of themorphdom
dependency or rename themorph
operation tomorphdom
we should just do it.In order to support other morphing libraries such as idiomorph, micromorph, nanomorph, diffhtml, @alpinejs/morph and diffDOM (including morphdom) we can provide operation packages that people can install and include, similar to how
@cable_ready/audio_operations
and@cable_ready/alpine_morph
works.With that approach we can package and import the individual morph libraries independently like:
Checklist