Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on the version difference between npm and gem although they are identical #649

Closed
jibees opened this issue Mar 27, 2023 · 0 comments · Fixed by #650
Closed

Error on the version difference between npm and gem although they are identical #649

jibees opened this issue Mar 27, 2023 · 0 comments · Fixed by #650

Comments

@jibees
Copy link
Contributor

jibees commented Mar 27, 2023

Bug Report

Describe the bug

Upgrading cable_ready and stimulus_reflex to latest version (ie. rc1), warns me around version mismatch:

stimulus_reflex.js:667 Reflex failed due to cable_ready gem/NPM package version mismatch. Package versions must match exactly.
Note that if you are using pre-release builds, gems use the "x.y.z.preN" version format, while NPM packages use "x.y.z-preN".

cable_ready gem: 5.0.0.rc1
cable_ready NPM: 5.0.0-rc1

To Reproduce

Upgrade both stimulus_reflex and cable_ready to latest rc1 for gems and npm packages. Launch your server; trigger a reflex on your app: this leads you to the warning in the browser console.

Expected behavior

A clear and concise description of what you expected to happen.

Versions

StimulusReflex

  • Gem: 3.5.0.rc1
  • Node package: 3.5.0-rc1
This was referenced Mar 27, 2023
Merged
Merged
marcoroth pushed a commit that referenced this issue Mar 27, 2023
@jibees
Also add rc as a suffix for versions comparison (#650)
0065b00 
Simply add `rc` as suffix as `pre` is a suffix used in version. 

Fixes #649

## Why should this be added

Since the rc has been released, we should compare versions between gem
and npm taking into account the `rc` suffix (and not only `pre`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Versions comparaison: rc is also a suffix (as pre). jibees/stimulus_reflex
1 participant
@jibees