Versions comparaison: rc is also a suffix (as pre).
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stimulusreflex ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jibees
force-pushed
the
Versioning-`rc`-is-also-as-a-suffix-used
branch
from
1a8a4d5 to
a5e9d4e
Compare
2 tasks
marcoroth
added a commit
that referenced
this pull request
Mar 27, 2023
#651) Following up on #641 and #650, this pull request also shows version mismatch toasts when the CableReady versions don't match. Perviously it would just show toast messages when the StimulusReflex versions didn't match. ## Why should this be added Previously this just showed a console error message when the user enabled the client-side `debug` option to `true`. Now this message is always printed, regular of the option. But additionally it now shows a version mismatch toast message when the `debug` option is set to `true`:  This helps to know what's up and why a reflex action might not have worked. If you didn't have the console open you wouldn't know why the reflex action didn't work.
|
This fix has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Simply add
rcas suffix aspreis a suffix used in version.Description
Simply add
rcas suffix aspreis a suffix used in version.Fixes #649
Why should this be added
Since the rc has been released, we should compare versions between gem and npm taking into account the
rcsuffix (and not onlypre)Checklist