Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Revision V silicon #9

Open
richardeoin opened this issue Jun 13, 2019 · 5 comments
Open

Tracking Issue for Revision V silicon #9

richardeoin opened this issue Jun 13, 2019 · 5 comments

Comments

@richardeoin
Copy link
Member

ST has released a new silicon revision for the H742/742/750/753 with significant changes.

Please report or tag issues with Revision V here! Also see upstream.

@hargoniX
Copy link
Member

In the eevblog link above I see two notes regarding the ADC (which as mentioned in #10 would've been my next addition)

-ADC Now has a extra 'divide by 2' on its clock inside it, making existing clock configurations too slow
-Changes to the ADC registers (For example a value in a register that used to set the ADC to 8bit mode is now setting it to 'reserved' so likely doesn't work)

Now I assume this could be easily resolved using feature gates, however a feature gate named "V" or "Revision-V" might be hard for the average user to understand as they are probably not aware of Revision V.

@richardeoin
Copy link
Member Author

Yes, these are significant changes! For now I say implement for Rev Y, then add -rev_v feature gates when someone has V silicon to test on.

@jordens
Copy link
Member

jordens commented Jun 17, 2019

FYI: The NUCLEO-H743ZI2 I just got from Digikey has Silicon rev V (and non-detachable ST-Link-v3)

@jordens
Copy link
Member

jordens commented Jul 11, 2019

stm32-rs/stm32-rs#247 for the PAC split.

richardeoin added a commit to richardeoin/stm32h7xx-hal that referenced this issue Jul 21, 2019
Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9
richardeoin added a commit to richardeoin/stm32h7xx-hal that referenced this issue Jul 21, 2019
Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9
richardeoin added a commit to richardeoin/stm32h7xx-hal that referenced this issue Jul 22, 2019
Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9
bors bot added a commit that referenced this issue Jul 22, 2019
25: revision_v: Update feature gates from revision v split in PAC r=richardeoin a=richardeoin

Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
#9

Co-authored-by: Richard Meadows <[email protected]>
@jordens
Copy link
Member

jordens commented Jul 29, 2019

@richardeoin Can we close this? The crates/features are nicely split to address this, right?

mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
25: revision_v: Update feature gates from revision v split in PAC r=richardeoin a=richardeoin

Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9

Co-authored-by: Richard Meadows <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants