Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision_v: Update feature gates from revision v split in PAC #25

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

richardeoin
Copy link
Member

Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
#9

Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one mixup

src/adc.rs Outdated Show resolved Hide resolved
src/adc.rs Outdated Show resolved Hide resolved
Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9
@richardeoin
Copy link
Member Author

Sorted. I also added details about Rev V in the README.

bors r+

bors bot added a commit that referenced this pull request Jul 22, 2019
25: revision_v: Update feature gates from revision v split in PAC r=richardeoin a=richardeoin

Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
#9

Co-authored-by: Richard Meadows <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 22, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 35ec519 into stm32-rs:master Jul 22, 2019
@richardeoin richardeoin deleted the stm32rs-v-variants branch September 12, 2019 17:30
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this pull request Jul 9, 2020
25: revision_v: Update feature gates from revision v split in PAC r=richardeoin a=richardeoin

Upstream change in stm32-rs
stm32-rs/stm32-rs#247

Remove feature gates where they are not required.

Add new v feature targets to travis.

ADC is currently the only area where this crate differs between v and
non-v.

Revision v tracking issue
stm32-rs#9

Co-authored-by: Richard Meadows <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants