Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error: Ember is not defined(Ember ~v4.4.0) in production builds #158

Closed
Windvis opened this issue Nov 21, 2022 · 0 comments · Fixed by #183
Closed

[Bug] Error: Ember is not defined(Ember ~v4.4.0) in production builds #158

Windvis opened this issue Nov 21, 2022 · 0 comments · Fixed by #183
Labels
bug Something isn't working

Comments

@Windvis
Copy link

Windvis commented Nov 21, 2022

Describe the bug

We're running into the exact same issue as #103 with the exception that in only happens when creating a production build of the "dummy" app.

Steps to reproduce the behavior

  1. set up Storybook in an Ember v4 based addon blueprint
  2. run ember build --environment=production to create a production build of the dummy app
  3. run build-storybook
  4. serve the final output npx http-server ./storybook-static
  5. open a Story that contains a component
  6. The Ember is not defined message will be shown in the preview section

Expected behavior

The component is rendered as normal.

Environment

  • Node.js version: 14.20.1
  • NPM version: 6.14.17

Additional context

This check fails because assets/vendor.js does not exist in production builds. The file will contain a hash instead: assets/vendor-some-hash-1234.js.

@Windvis Windvis added the bug Something isn't working label Nov 21, 2022
@Windvis Windvis changed the title [Bug] Error: Ember is not defined (Ember ~v4.4.0) in production builds [Bug] Error: Ember is not defined(Ember ~v4.4.0) in production builds Nov 21, 2022
Windvis added a commit to appuniversum/ember-appuniversum that referenced this issue Nov 21, 2022
It seems that ember-cli-storybook doesn't support using a production build of the dummy app yet. Once that is resolved we can switch back to a production build if needed.

More information: storybookjs/ember-cli-storybook#158
Windvis added a commit to appuniversum/ember-appuniversum that referenced this issue Nov 21, 2022
This is a workaround for an ember-cli-storybook issue: storybookjs/ember-cli-storybook#158

Once that is resolved we can enable fingerprinting again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant