Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert the global ember import on production build #183

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Insert the global ember import on production build #183

merged 2 commits into from
Aug 16, 2023

Conversation

francois2metz
Copy link
Contributor

Fix #158
I got a working storybook 7 + ember with storybookjs/storybook#23435 and this patch.

@francois2metz francois2metz mentioned this pull request Jul 17, 2023
Merged
5 tasks
gossi
gossi reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@gossi gossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me. Matching the hash, we all have workarounds for =)

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@ember/string 3.1.1 None +0 32.2 kB katiegengler

@shilman shilman merged commit 33cb2b2 into storybookjs:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gossi gossi gossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Error: Ember is not defined(Ember ~v4.4.0) in production builds
3 participants
@francois2metz @gossi @shilman