Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Re-export essentials sub-addon preview annotations for pnpm #19689

Merged
merged 40 commits into from
Nov 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
87582dc
Vite: Re-export essentials sub-addon preview annotations for pnpm
IanVS Oct 31, 2022
cec6654
Standardize addon preview location / export
IanVS Nov 2, 2022
a61403a
Use /dist/preview in addons
IanVS Nov 2, 2022
ede9562
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 2, 2022
9fe7fdc
Upgrade to TS 4.8
IanVS Nov 2, 2022
d41699a
Use Node16 moduleResolution
IanVS Nov 2, 2022
9264795
Add typescript eslint resolver
IanVS Nov 2, 2022
edb90d6
Remove /dist from exports & imports
IanVS Nov 2, 2022
8c62083
Update typescript in /scripts too
IanVS Nov 2, 2022
4560a33
Limit Node16 to only where it's needed, for now
IanVS Nov 3, 2022
0add1a9
Fix TS 4.8 errors
IanVS Nov 3, 2022
3d8d1a1
Restore moduleResolution in scripts
IanVS Nov 3, 2022
00bb65c
downgrade eslint-import-resolver-typescript
IanVS Nov 3, 2022
1f6b189
Remove typescript import resolver for now
IanVS Nov 3, 2022
39055be
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 3, 2022
af941fd
Add typesVersions to addons
IanVS Nov 3, 2022
aaa4a21
Re-export all addons from addon-essentials
IanVS Nov 3, 2022
756ea18
Keep addons relative, but use addon-essentials re-exports
IanVS Nov 3, 2022
0e8b0ba
Remove node16 moduleResolution
IanVS Nov 3, 2022
afaf141
Adjust builder-vite ssv6
IanVS Nov 3, 2022
2db1bc7
Remove unused imports
IanVS Nov 3, 2022
e7dc1c3
Remove unused eslint disable directives
IanVS Nov 3, 2022
f640293
Revert "Upgrade to TS 4.8"
IanVS Nov 4, 2022
8dda382
Revert "Fix TS 4.8 errors"
IanVS Nov 4, 2022
744051b
Revert "Update typescript in /scripts too"
IanVS Nov 4, 2022
e9d30c8
Update hasDocsOrControls to account for new path
IanVS Nov 4, 2022
2327569
Fix builder-webpack5 exports paths
IanVS Nov 4, 2022
a291e26
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 4, 2022
4af0653
Remove unrelated change
IanVS Nov 4, 2022
50826f2
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 8, 2022
b793868
Maintain WP back-compat by using tuple of [bare, absolute]
IanVS Nov 8, 2022
5bcd1e3
Add warning for super-addons not re-exporting their sub-addons
IanVS Nov 8, 2022
4931ec8
Fix deepscan
IanVS Nov 8, 2022
deb3b35
Remove warning
IanVS Nov 8, 2022
e23737e
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 8, 2022
4e15f69
Fix addon handling in SSv6
IanVS Nov 8, 2022
0813b24
Fix pnpm storybook module imports for SSv6
IanVS Nov 8, 2022
0428198
Remove errant console.log
IanVS Nov 8, 2022
18a6ba9
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS Nov 8, 2022
9d9a92d
Use an object instead of tuple for previewAnnotations
IanVS Nov 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused imports
IanVS committed Nov 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 2db1bc7e3ce3b8bcda97968d244fb155cbaa623e
2 changes: 1 addition & 1 deletion code/addons/essentials/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import path, { dirname, join } from 'path';
import path from 'path';
import { logger } from '@storybook/node-logger';
import { serverRequire } from '@storybook/core-common';

1 change: 0 additions & 1 deletion code/lib/core-common/src/presets.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { dedent } from 'ts-dedent';
import { logger } from '@storybook/node-logger';
import { dirname } from 'path';
import type {
BuilderOptions,
CLIOptions,