-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite: Re-export essentials sub-addon preview annotations for pnpm #19689
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
87582dc
Vite: Re-export essentials sub-addon preview annotations for pnpm
IanVS cec6654
Standardize addon preview location / export
IanVS a61403a
Use /dist/preview in addons
IanVS ede9562
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS 9fe7fdc
Upgrade to TS 4.8
IanVS d41699a
Use Node16 moduleResolution
IanVS 9264795
Add typescript eslint resolver
IanVS edb90d6
Remove /dist from exports & imports
IanVS 8c62083
Update typescript in /scripts too
IanVS 4560a33
Limit Node16 to only where it's needed, for now
IanVS 0add1a9
Fix TS 4.8 errors
IanVS 3d8d1a1
Restore moduleResolution in scripts
IanVS 00bb65c
downgrade eslint-import-resolver-typescript
IanVS 1f6b189
Remove typescript import resolver for now
IanVS 39055be
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS af941fd
Add typesVersions to addons
IanVS aaa4a21
Re-export all addons from addon-essentials
IanVS 756ea18
Keep addons relative, but use addon-essentials re-exports
IanVS 0e8b0ba
Remove node16 moduleResolution
IanVS afaf141
Adjust builder-vite ssv6
IanVS 2db1bc7
Remove unused imports
IanVS e7dc1c3
Remove unused eslint disable directives
IanVS f640293
Revert "Upgrade to TS 4.8"
IanVS 8dda382
Revert "Fix TS 4.8 errors"
IanVS 744051b
Revert "Update typescript in /scripts too"
IanVS e9d30c8
Update hasDocsOrControls to account for new path
IanVS 2327569
Fix builder-webpack5 exports paths
IanVS a291e26
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS 4af0653
Remove unrelated change
IanVS 50826f2
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS b793868
Maintain WP back-compat by using tuple of [bare, absolute]
IanVS 5bcd1e3
Add warning for super-addons not re-exporting their sub-addons
IanVS 4931ec8
Fix deepscan
IanVS deb3b35
Remove warning
IanVS e23737e
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS 4e15f69
Fix addon handling in SSv6
IanVS 0813b24
Fix pnpm storybook module imports for SSv6
IanVS 0428198
Remove errant console.log
IanVS 18a6ba9
Merge remote-tracking branch 'origin/next' into nested-addons
IanVS 9d9a92d
Use an object instead of tuple for previewAnnotations
IanVS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-actions/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable import/export */ | ||
// TODO: We need to configure an eslint-import typescript resolver for export maps to be considered | ||
|
||
export * from '@storybook/addon-actions/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-backgrounds/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable import/export */ | ||
// TODO: We need to configure an eslint-import typescript resolver for export maps to be considered | ||
|
||
export * from '@storybook/addon-backgrounds/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-controls/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from '@storybook/addon-docs/preset'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from '@storybook/addon-docs/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable import/export */ | ||
// TODO: We need to configure an eslint-import typescript resolver for export maps to be considered | ||
|
||
export * from '@storybook/addon-highlight/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-measure/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable import/export */ | ||
// TODO: We need to configure an eslint-import typescript resolver for export maps to be considered | ||
|
||
export * from '@storybook/addon-measure/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-outline/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable import/export */ | ||
// TODO: We need to configure an eslint-import typescript resolver for export maps to be considered | ||
|
||
export * from '@storybook/addon-outline/preview'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-toolbars/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
declare module 'fs'; | ||
|
||
// TODO: Remove this once addon-docs is generated with tsup | ||
declare module '@storybook/addon-docs/preview'; | ||
declare module '@storybook/addon-docs/preset'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// @ts-expect-error The generated definition file is empty. https://github.com/egoist/tsup/issues/762 | ||
export * from '@storybook/addon-viewport/manager'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export * from './dist/highlight'; | ||
export * from './dist/preview'; |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,9 +33,9 @@ | |
"types": "./dist/manager.d.ts" | ||
}, | ||
"./preview": { | ||
"require": "./dist/preset/preview.js", | ||
"import": "./dist/preset/preview.mjs", | ||
"types": "./dist/preset/preview.d.ts" | ||
"require": "./dist/preview.js", | ||
"import": "./dist/preview.mjs", | ||
"types": "./dist/preview.d.ts" | ||
}, | ||
"./register.js": { | ||
"require": "./dist/manager.js", | ||
|
@@ -47,6 +47,19 @@ | |
"main": "dist/index.js", | ||
"module": "dist/index.mjs", | ||
"types": "dist/index.d.ts", | ||
"typesVersions": { | ||
"*": { | ||
"*": [ | ||
"dist/index.d.ts" | ||
], | ||
"manager": [ | ||
"dist/manager.d.ts" | ||
], | ||
"preview": [ | ||
"dist/preview.d.ts" | ||
] | ||
} | ||
}, | ||
"files": [ | ||
"dist/**/*", | ||
"README.md", | ||
|
@@ -99,7 +112,7 @@ | |
"entries": [ | ||
"./src/index.ts", | ||
"./src/manager.tsx", | ||
"./src/preset/preview.ts", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could also have remained as before, but it was inconsistent with the rest of the addons, and it's nice for them all to follow the same pattern. I did the same for |
||
"./src/preview.ts", | ||
"./src/preset/checkActionsLoaded.ts" | ||
], | ||
"platform": "node" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export * from './dist/preset/preview'; | ||
export * from './dist/preview'; |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change wasn't entirely necessary here, but seemed like a good idea to keep the addons consistent with each other.