Crates were not bumped in PR #1230

[GitGab19]

PR #1230 changed some crates under protocols to be no_std, without bumping their versions.

Now this is creating some errors in the CI execution of semver-checks, such as here: https://github.com/stratum-mining/stratum/actions/runs/12211524808/job/34069218188?pr=1242.

We need to bump versions of crates which were modified there to fix this and unblock all the docs PRs.

Specifically, we need to bump the major version number of:

• serde_sv2
• const_sv2
• framing_sv2

[jbesraa]

I would remove the semver check from ci and move it into a script that we run manually before creating a new release

[plebhash]

I would remove the semver check from ci and move it into a script that we run manually before creating a new release

@GitGab19 feels we should catch semver deviations as soon as possible, and I tend to agree

but it's also important to highlight that something is not working as expected

we merged #1230 without CI blocks, and now we are getting this behavior

ideally #1230 should have been blocked by this semver check

[Fi3]

Nack on running server checks manually. This will inevitably lead to broken versions.

…

On Sun, Dec 8, 2024, 4:38 PM plebhash ***@***.***> wrote: I would remove the semver check from ci and move it into a script that we run manually before creating a new release @GitGab19 <https://github.com/GitGab19> feels we should catch semver deviations as soon as possible, and I tend to agree but it's also important to highlight that something is not working as expected we merged #1230 <#1230> without CI blocks, and now we are getting this behavior ideally #1230 <#1230> should have been blocked by this semver check — Reply to this email directly, view it on GitHub <#1275 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPLMPIIBBLVUUQ3AA3GWYD2EQ4SVAVCNFSM6AAAAABTGEHGGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVG42TKOBVGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[plebhash]

we merged #1230 without CI blocks, and now we are getting this behavior

ideally #1230 should have been blocked by this semver check

this happened because our CI was using whatever was the latest release of cargo semver-checks, and obi1kenobi/cargo-semver-checks#1015 introduced a change of behavior into v0.37.0, which was released only 4 days ago (which explains the recent change of CI behavior)

the solution was #1276 where we are locking CI to always use cargo semver-checks on release v0.33.0 in order to always have the same behavior of the tool

[plebhash]

todo: follow up to #1276 that locks cargo semver-checks on 0.37.0

this CI will have to run on rust stable