Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock version for cargo semver-checks #1276

Merged
merged 1 commit into from
Dec 9, 2024
Merged

lock version for cargo semver-checks #1276

merged 1 commit into from
Dec 9, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Dec 8, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.30%. Comparing base (d0970a8) to head (e85cf83).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1276   +/-   ##
=======================================
  Coverage   19.30%   19.30%           
=======================================
  Files         164      164           
  Lines       10849    10849           
=======================================
  Hits         2094     2094           
  Misses       8755     8755
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.46% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 8.06% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

🐰 Bencher Report

Branchlock-semver-checks-version
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,630.20
(-1.32%)		7,161.03
(92.59%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,511.40
(-1.44%)		8,136.34
(92.32%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,179.30
(-0.18%)		8,667.33
(94.37%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		854.80
(-1.28%)		934.64
(91.46%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		669.49
(-0.45%)		709.38
(94.38%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		245.12
(-1.84%)		278.64
(87.97%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.37
(-0.54%)		163.53
(95.62%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,348.20
(-2.68%)		7,284.36
(87.15%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		279.97
(-0.07%)		309.46
(90.47%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		729.19
(-0.22%)		793.16
(91.94%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		586.52
(-1.45%)		641.36
(91.45%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.00
(-0.34%)		216.61
(94.64%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

🐰 Bencher Report

Branchlock-semver-checks-version
Testbedsv2

🚨 5 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_handle_message_miningEstimated Cycles
estimated cycles		📈 plot
🚨 alert (🔔)
🚷 threshold		8,322.00
(+1.43%)		8,296.75
(100.30%)
client_sv2_handle_message_miningRAM Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		142.00
(+2.13%)		141.32
(100.48%)
client_sv2_mining_message_submit_standard_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		55.00
(+26.35%)		54.06
(101.75%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		94.00
(+15.38%)		90.65
(103.69%)
client_sv2_open_channel_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		45.00
(+27.97%)		44.08
(102.09%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,095.00
(-0.08%)		2,214.37
(94.61%)		📈 view plot
🚷 view threshold		473.00
(-0.06%)		488.62
(96.80%)		📈 view plot
🚷 view threshold		735.00
(-0.12%)		757.46
(97.03%)		📈 view plot
🚷 view threshold		6.00
(+13.44%)		13.54
(44.32%)		📈 view plot
🚷 view threshold		38.00
(-0.33%)		41.38
(91.84%)
client_sv2_handle_message_mining📈 view plot
🚨 view alert (🔔)
🚷 view threshold		8,322.00
(+1.43%)		8,296.75
(100.30%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,152.00
(-0.28%)		3,170.89
(99.40%)		📈 view plot
🚷 view threshold		40.00
(+12.75%)		41.90
(95.47%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		142.00
(+2.13%)		141.32
(100.48%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,331.00
(+0.78%)		6,404.20
(98.86%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,766.99
(99.04%)		📈 view plot
🚷 view threshold		2,546.00
(-0.29%)		2,576.01
(98.84%)		📈 view plot
🚷 view threshold		22.00
(+30.25%)		24.31
(90.48%)		📈 view plot
🚷 view threshold		105.00
(+0.85%)		107.50
(97.67%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,790.00
(+0.42%)		14,951.83
(98.92%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,710.99
(99.64%)		📈 view plot
🚷 view threshold		6,745.00
(-0.20%)		6,783.00
(99.44%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		55.00
(+26.35%)		54.06
(101.75%)		📈 view plot
🚷 view threshold		222.00
(+0.24%)		227.36
(97.64%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,766.00
(+0.82%)		27,846.47
(99.71%)		📈 view plot
🚷 view threshold		10,645.00
(+0.56%)		10,659.54
(99.86%)		📈 view plot
🚷 view threshold		15,501.00
(+0.62%)		15,524.64
(99.85%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		94.00
(+15.38%)		90.65
(103.69%)		📈 view plot
🚷 view threshold		337.00
(+0.57%)		341.82
(98.59%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,451.00
(+1.32%)		4,588.88
(97.00%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,476.62
(98.94%)		📈 view plot
🚷 view threshold		2,156.00
(-0.19%)		2,184.25
(98.71%)		📈 view plot
🚷 view threshold		11.00
(+25.94%)		16.70
(65.88%)		📈 view plot
🚷 view threshold		64.00
(+2.32%)		67.85
(94.32%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,052.00
(+0.05%)		14,371.85
(97.77%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,079.62
(99.69%)		📈 view plot
🚷 view threshold		7,317.00
(-0.13%)		7,351.85
(99.53%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		45.00
(+27.97%)		44.08
(102.09%)		📈 view plot
🚷 view threshold		186.00
(-0.51%)		196.38
(94.72%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,888.00
(+0.98%)		22,928.89
(99.82%)		📈 view plot
🚷 view threshold		8,040.00
(+0.21%)		8,072.04
(99.60%)		📈 view plot
🚷 view threshold		11,688.00
(+0.14%)		11,747.89
(99.49%)		📈 view plot
🚷 view threshold		84.00
(+12.88%)		85.34
(98.44%)		📈 view plot
🚷 view threshold		308.00
(+1.49%)		311.23
(98.96%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,677.00
(-0.17%)		4,778.42
(97.88%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.62
(98.97%)		📈 view plot
🚷 view threshold		2,277.00
(-0.06%)		2,299.29
(99.03%)		📈 view plot
🚷 view threshold		11.00
(+15.03%)		16.60
(66.25%)		📈 view plot
🚷 view threshold		67.00
(-0.59%)		69.90
(95.85%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,184.00
(+0.12%)		16,432.55
(98.49%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.62
(99.74%)		📈 view plot
🚷 view threshold		8,654.00
(-0.11%)		8,691.70
(99.57%)		📈 view plot
🚷 view threshold		50.00
(+25.51%)		53.15
(94.07%)		📈 view plot
🚷 view threshold		208.00
(-0.30%)		215.62
(96.47%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,774.00
(+0.61%)		35,796.63
(99.94%)		📈 view plot
🚷 view threshold		14,888.00
(+0.24%)		14,910.69
(99.85%)		📈 view plot
🚷 view threshold		21,869.00
(+0.22%)		21,922.91
(99.75%)		📈 view plot
🚷 view threshold		107.00
(+16.15%)		110.96
(96.43%)		📈 view plot
🚷 view threshold		382.00
(+0.70%)		385.05
(99.21%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

🐰 Bencher Report

Branchlock-semver-checks-version
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.26
(+1.62%)		47.11
(96.07%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		72.13
(-2.91%)		80.24
(89.90%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.69
(+0.17%)		14.82
(99.17%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		264.43
(+0.42%)		306.42
(86.30%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		612.62
(-0.27%)		705.98
(86.78%)
client_sv2_open_channel📈 view plot
🚷 view threshold		162.95
(+5.00%)		197.94
(82.32%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		292.49
(+2.71%)		313.96
(93.16%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		376.36
(-0.80%)		404.24
(93.10%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		167.57
(+4.11%)		174.15
(96.22%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		459.61
(-1.51%)		541.47
(84.88%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,004.60
(+1.88%)		1,110.66
(90.45%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

🐰 Bencher Report

Branchlock-semver-checks-version
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,380.00
(-1.00%)		8,731.53
(95.97%)		📈 view plot
🚷 view threshold		3,663.00
(-2.26%)		3,861.02
(94.87%)		📈 view plot
🚷 view threshold		5,110.00
(-2.74%)		5,434.16
(94.03%)		📈 view plot
🚷 view threshold		10.00
(+37.04%)		13.55
(73.80%)		📈 view plot
🚷 view threshold		92.00
(+1.44%)		95.36
(96.48%)
get_submit📈 view plot
🚷 view threshold		95,298.00
(-0.14%)		95,887.51
(99.39%)		📈 view plot
🚷 view threshold		59,263.00
(-0.32%)		59,694.68
(99.28%)		📈 view plot
🚷 view threshold		85,073.00
(-0.38%)		85,780.53
(99.18%)		📈 view plot
🚷 view threshold		50.00
(+11.83%)		63.01
(79.35%)		📈 view plot
🚷 view threshold		285.00
(+1.71%)		289.60
(98.41%)
get_subscribe📈 view plot
🚷 view threshold		7,897.00
(-1.55%)		8,276.85
(95.41%)		📈 view plot
🚷 view threshold		2,758.00
(-2.67%)		2,940.61
(93.79%)		📈 view plot
🚷 view threshold		3,832.00
(-3.22%)		4,126.39
(92.87%)		📈 view plot
🚷 view threshold		15.00
(+25.49%)		20.56
(72.96%)		📈 view plot
🚷 view threshold		114.00
(-0.30%)		118.56
(96.15%)
serialize_authorize📈 view plot
🚷 view threshold		12,169.00
(-0.92%)		12,566.51
(96.84%)		📈 view plot
🚷 view threshold		5,240.00
(-1.50%)		5,428.13
(96.53%)		📈 view plot
🚷 view threshold		7,279.00
(-1.86%)		7,591.87
(95.88%)		📈 view plot
🚷 view threshold		12.00
(+30.61%)		16.53
(72.58%)		📈 view plot
🚷 view threshold		138.00
(+0.22%)		142.65
(96.74%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,564.00
(-0.53%)		25,221.54
(97.39%)		📈 view plot
🚷 view threshold		9,786.00
(-1.04%)		10,037.56
(97.49%)		📈 view plot
🚷 view threshold		13,789.00
(-1.23%)		14,194.13
(97.15%)		📈 view plot
🚷 view threshold		34.00
(-1.87%)		43.63
(77.93%)		📈 view plot
🚷 view threshold		303.00
(+0.42%)		315.00
(96.19%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,163.00
(-0.54%)		30,749.64
(98.09%)		📈 view plot
🚷 view threshold		11,989.00
(-0.75%)		12,206.00
(98.22%)		📈 view plot
🚷 view threshold		16,953.00
(-0.89%)		17,299.35
(98.00%)		📈 view plot
🚷 view threshold		59.00
(+6.16%)		67.47
(87.45%)		📈 view plot
🚷 view threshold		369.00
(-0.21%)		381.50
(96.72%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,476.00
(0.00%)		126,895.04
(99.67%)		📈 view plot
🚷 view threshold		73,117.00
(-0.23%)		73,517.40
(99.46%)		📈 view plot
🚷 view threshold		104,756.00
(-0.29%)		105,451.44
(99.34%)		📈 view plot
🚷 view threshold		116.00
(+8.53%)		132.16
(87.77%)		📈 view plot
🚷 view threshold		604.00
(+1.24%)		605.91
(99.69%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,787.00
(-0.22%)		28,591.43
(97.19%)		📈 view plot
🚷 view threshold		9,577.00
(-0.74%)		9,754.26
(98.18%)		📈 view plot
🚷 view threshold		13,522.00
(-0.91%)		13,811.75
(97.90%)		📈 view plot
🚷 view threshold		67.00
(+5.42%)		76.17
(87.96%)		📈 view plot
🚷 view threshold		398.00
(+0.33%)		416.53
(95.55%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,177.00
(-0.06%)		115,793.31
(99.47%)		📈 view plot
🚷 view threshold		67,894.00
(-0.31%)		68,403.34
(99.26%)		📈 view plot
🚷 view threshold		97,357.00
(-0.38%)		98,239.75
(99.10%)		📈 view plot
🚷 view threshold		71.00
(+13.06%)		78.78
(90.12%)		📈 view plot
🚷 view threshold		499.00
(+1.53%)		499.31
(99.94%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,172.00
(-0.41%)		23,976.44
(96.64%)		📈 view plot
🚷 view threshold		8,129.00
(-0.91%)		8,310.27
(97.82%)		📈 view plot
🚷 view threshold		11,427.00
(-1.10%)		11,718.84
(97.51%)		📈 view plot
🚷 view threshold		39.00
(+4.57%)		44.63
(87.39%)		📈 view plot
🚷 view threshold		330.00
(+0.20%)		347.43
(94.98%)
serialize_submit📈 view plot
🚷 view threshold		99,755.00
(-0.09%)		100,299.96
(99.46%)		📈 view plot
🚷 view threshold		61,325.00
(-0.29%)		61,726.71
(99.35%)		📈 view plot
🚷 view threshold		87,930.00
(-0.35%)		88,613.52
(99.23%)		📈 view plot
🚷 view threshold		55.00
(+17.63%)		64.56
(85.20%)		📈 view plot
🚷 view threshold		330.00
(+1.58%)		334.33
(98.70%)
serialize_subscribe📈 view plot
🚷 view threshold		11,376.00
(-0.26%)		11,677.84
(97.42%)		📈 view plot
🚷 view threshold		4,111.00
(-1.68%)		4,283.50
(95.97%)		📈 view plot
🚷 view threshold		5,691.00
(-2.16%)		5,979.38
(95.18%)		📈 view plot
🚷 view threshold		17.00
(+31.72%)		21.00
(80.94%)		📈 view plot
🚷 view threshold		160.00
(+1.36%)		163.43
(97.90%)
🐰 View full continuous benchmarking report in Bencher

@plebhash plebhash force-pushed the lock-semver-checks-version branch from 8602aaf to 93b58f8 Compare December 8, 2024 17:11
@plebhash plebhash force-pushed the lock-semver-checks-version branch from 93b58f8 to f058d60 Compare December 9, 2024 07:20
@plebhash plebhash force-pushed the lock-semver-checks-version branch from f058d60 to e85cf83 Compare December 9, 2024 07:21
@plebhash plebhash merged commit 2543595 into stratum-mining:main Dec 9, 2024
38 checks passed
@plebhash plebhash deleted the lock-semver-checks-version branch December 9, 2024 07:42
@plebhash plebhash mentioned this pull request Dec 9, 2024
Closed
@plebhash plebhash mentioned this pull request Dec 16, 2024
Merged
plebhash added a commit that referenced this pull request Dec 18, 2024
@plebhash
Merge pull request #1300 from plebhash/semver-checks-37
bf68d8e 
use `cargo semver-checks` v0.37 and bump crate versions as a follow-up to #1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plebhash @GitGab19