Allow KafkaRoller talk to controller directly #10016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaselenge
force-pushed
the
add-controller-svc
branch
2 times, most recently
from
c256f5a to
93053e7
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
3 times, most recently
from
1bf6fab to
0f6d51f
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
from
0f6d51f to
eefbd4c
Compare
scholzj
reviewed
Aug 28, 2024
...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
tinaselenge
force-pushed
the
add-controller-svc
branch
2 times, most recently
from
52d9241 to
bb928d6
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
from
bb928d6 to
6e03523
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I will check the regression test failures. |
|
@scholzj can you please kick off the regression tests again? The failed system tests seem to pass for me when running locally. |
|
@tinaselenge could you please rebase to avoid running |
tinaselenge
force-pushed
the
add-controller-svc
branch
from
6e03523 to
99cc9e2
Compare
|
thanks @Frawless . I rebased now. |
|
/azp run regression |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I started the regressions. But the Unit test failure seems related to your PR. |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Nov 25, 2024
operator-common/src/main/java/io/strimzi/operator/common/Annotations.java
Outdated
Show resolved
Hide resolved
operator-common/src/test/java/io/strimzi/operator/common/DefaultAdminClientProviderTest.java
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Outdated
Show resolved
Hide resolved
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I'm trying to run the STs on this with Kafka 3.8.1. But assuming they pass, this looks good to me. Thanks @tinaselenge.
|
Thank you @scholzj! |
ppatierno
reviewed
Nov 27, 2024
operator-common/src/main/java/io/strimzi/operator/common/AdminClientProvider.java
Show resolved
Hide resolved
scholzj
reviewed
Nov 27, 2024
operator-common/src/test/java/io/strimzi/operator/common/DefaultAdminClientProviderTest.java
Outdated
Show resolved
Hide resolved
Update AdminClientProvider to create an admin client for controllers with BOOTSTRAP_CONTROLLERS_CONFIG set. Allow KafkaRoller create admin client against controllers nodes, if they are running 3.9.0 or later. Remove ceShouldBeFatal option as it's never set to true. Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
add-controller-svc
branch
from
d249582 to
dc4024a
Compare
ppatierno
approved these changes
Nov 28, 2024
|
Thanks for the PR @tinaselenge |
This was referenced Dec 3, 2024
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Gantigmaa Selenge <[email protected]>
3 tasks
8 tasks
tinaselenge
added a commit
to tinaselenge/strimzi-kafka-operator
that referenced
this pull request
Dec 12, 2024
This reverts commit 1f1a16d. This commit caused Warning messages indicating that describeQuorum request was sent to a non active controller therefore failed rolling a controller-only node. We discovered that non active controller does not forward the request to the active controller like broker does, but returns NOT_LEADER_OR_FOLLOWER error. This issue gets resolved by itself eventually after retrying the request several times, because the describeQuorum gets sent to the active controller at some point. However, it could cause some delay in rolling controller-only nodes, due to the number of retrying. Reverting this commit from 0.45.0 release branch, and the issue will be fixed properly in the main branch to target the next release.
tinaselenge
added a commit
to tinaselenge/strimzi-kafka-operator
that referenced
this pull request
Dec 12, 2024
This reverts commit 1f1a16d. This commit caused Warning messages indicating that describeQuorum request was sent to a non active controller therefore failed rolling a controller-only node. We discovered that non active controller does not forward the request to the active controller like broker does, but returns NOT_LEADER_OR_FOLLOWER error. This issue gets resolved by itself eventually after retrying the request several times, because the describeQuorum gets sent to the active controller at some point. However, it could cause some delay in rolling controller-only nodes, due to the number of retrying. Reverting this commit from 0.45.0 release branch, and the issue will be fixed properly in the main branch to target the next release. Signed-off-by: Gantigmaa Selenge <[email protected]>
scholzj
pushed a commit
that referenced
this pull request
Dec 12, 2024
…0.45.x release (#10944) Signed-off-by: Gantigmaa Selenge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
There will be a follow up PR to dynamically apply configurations for controllers (with version 3.9.0 or later) using the admin client instead of how we currently restart controllers when any config changes.
Closes #9692
Checklist
Please go through this checklist and make sure all applicable tasks have been done